Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64177

Fix problems reported in apache logs before 3.6 release

    XMLWordPrintable

    Details

      Description

      Running the https://docs.google.com/spreadsheets/d/1TcMJT3o2Cnyq006lmLWrXJeNQQzyNXz2E_Vbc8ff5EE/edit?pli=1#gid=0 release testing matrix for Moodle 3.6, in apache logs the following have been detected.

      A) There are like 4 debugging messages related with max_input_vars. Or the test calculations are wrong or something else has changed and we are exporting more vars than previously. Happens with (cm, ce, cl, al)

      [Wed Nov 21 12:01:13.718536 2018] [php7:warn] [pid 89726] [client 10.10.10.10:51821] PHP Warning: Unknown: Input variables exceeded 20000. To increase the limit change max_input_vars in php.ini. in Unknown on line 0, referer: http://10.10.10.10/~stronk7/behattesting/behatrun1/lib/tests/fixtures/max_input_vars.php?type=cm

      Note this seems to be related to the lib/tests/behat/largeforms.feature feature, because it's the only one including the lib/tests/fixtures/max_input_vars.php fixture.

      B) This is shown a lot of times along the run. Shouldn't be hard to fix.

      Debugging: Invalid get_string() identifier: 'starred' or component 'block_myoverview'. Perhaps you are missing $string['starred'] = ''; in /Users/stronk7/git_moodle/testing/blocks/myoverview/lang/en/block_myoverview.php? in \n* line 349 of /lib/classes/string_manager_standard.php: call to debugging()\n* line 117 of /lib/external/externallib.php: call to core_string_manager_standard->get_string()\n* line 244 of /lib/externallib.php: call to core_external::get_string()\n* line 59 of /lib/ajax/service.php: call to external_api::call_external_function()\n* line 31 of /lib/ajax/service-nologin.php: call to require_once()\n, referer: http://10.10.10.10/~stronk7/behattesting/behatrun1/my/

      That's all, so far, haven't seen anything else after a good number of runs, both with boost and clean.

      Note that the fixes maybe need to be backported to supported versions, specially A)

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated: