[MDL-64205] Invalid user error shows on Data requests page - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 3.3.9, 3.4.6, 3.5.3
Fix Version/s: 3.3.9, 3.4.7, 3.5.4
Component/s: Privacy
Labels:
- ci
- regression
- triaged

Affected Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
Fixed Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
Pull from Repository:
git://github.com/mudrd8mz/moodle.git
Pull Main Branch:
~~MDL-64205~~-master-sarunconfirmeduser
Pull Main Diff URL:
https://github.com/mudrd8mz/moodle/compare/0225ad42ea...MDL-64205-master-sarunconfirmeduser
Testing Instructions:
Hide

Put the following to your config.php

$CFG->deleteunconfirmed = 1 / 3600;

Go to Site administration > Plugins > Authentication > Manage authentication

Enable Self registration via email

Self-register as a new user

Run cron

Go to Site administration > Users > Privacy and policies > Data requests

TEST Confirm the error is not displayed and the page works as expected

Delete that added line from your config.php
Show
Put the following to your config.php $CFG->deleteunconfirmed = 1 / 3600; Go to Site administration > Plugins > Authentication > Manage authentication Enable Self registration via email Self-register as a new user Run cron Go to Site administration > Users > Privacy and policies > Data requests TEST Confirm the error is not displayed and the page works as expected Delete that added line from your config.php

Description

This has been originally reported by marycooch at her own site and I was able to reproduce it.

Say a user self-registers but does not confirm the account. Eventually the task delete_unconfirmed_users_task gets executed and an automatic request to delete the user's data is created (via the observer introduced in ~~MDL-62564~~), but the user's account is immediately deleted. So we end up with a record in the tool_dataprivacy_request table pointing to a non-existing userid.

I believe we should not delete the actual user record - even for unconfirmed users - same as we do not deleted them in the delete_incomplete_users_task

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-64205_integration33.PNG
34 kB
27/Nov/18 5:16 PM
MDL-64205_integration34.PNG
31 kB
27/Nov/18 4:38 PM
MDL-64205.PNG
41 kB
27/Nov/18 12:33 PM

Issue Links

is a regression caused by

MDL-62564 Improve bulk deletion

Closed

Activity

People

Assignee:: David Mudrák (@mudrd8mz)

Reporter:: David Mudrák (@mudrd8mz)

Peer reviewer:: Andrew Lyons

Integrator:: David Monllaó

Tester:: Anna Carissa Sadia

Participants:: Andrew Lyons, Anna Carissa Sadia, CiBoT, David Monllaó, David Mudrák (@mudrd8mz)

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 25/Nov/18 1:48 PM

Updated:: 28/Nov/18 10:36 PM

Resolved:: 28/Nov/18 10:36 PM

Fix Release Date:: 12/Nov/18

Time Tracking

Estimated:

Not Specified

Remaining:

Logged: