Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64206

Facebook Branding image address is wrong in oauth2

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Test 1
      1. Install a new site.
      2. Log in as an admin.
      3. Visit ‘Site administration’ > 'Server' > 'OAuth 2 services'.
      4. Click on 'Create new Facebook service'.
      5. Enter whatever you want in the required fields on the form and save.
      6. Visit 'Site administration' > 'Authentication' > 'Manage authentication'.
      7. Enable 'OAuth 2'.
      8. Log out.
      9. Go to the login/index.php page.
      10. Confirm there is a Facebook logo next to the text 'Facebook'.
      Test 2
      1. Install a Fresh site using git checkout 599703e83dcdb7ba34
      2. Log in as an admin.
      3. Visit ‘Site administration’ > 'Server' > 'OAuth 2 services'.
      4. Click on 'Create new Facebook service'.
      5. Enter whatever you want in the required fields on the form and save.
      6. Visit 'Site administration' > 'Authentication' > 'Manage authentication'.
      7. Enable 'OAuth 2'.
      8. Log out.
      9. Go to the login/index.php page.
      10. Confirm there is not a Facebook logo next to the text 'Facebook'.
      11. Log in as Admin.
      12. Upgrade to the latest version.
      13. Log out.
      14. Go to the login/index.php page.
      15. Confirm there is a Facebook logo next to the text 'Facebook'.
      Show
      Test 1 Install a new site. Log in as an admin. Visit ‘Site administration’ > 'Server' > 'OAuth 2 services'. Click on 'Create new Facebook service'. Enter whatever you want in the required fields on the form and save. Visit 'Site administration' > 'Authentication' > 'Manage authentication'. Enable 'OAuth 2'. Log out. Go to the login/index.php page. Confirm there is a Facebook logo next to the text 'Facebook'. Test 2 Install a Fresh site using git checkout 599703e83dcdb7ba34 Log in as an admin. Visit ‘Site administration’ > 'Server' > 'OAuth 2 services'. Click on 'Create new Facebook service'. Enter whatever you want in the required fields on the form and save. Visit 'Site administration' > 'Authentication' > 'Manage authentication'. Enable 'OAuth 2'. Log out. Go to the login/index.php page. Confirm there is not a Facebook logo next to the text 'Facebook'. Log in as Admin. Upgrade to the latest version. Log out. Go to the login/index.php page. Confirm there is a Facebook logo next to the text 'Facebook'.
    • Affected Branches:
      MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull 3.5 Diff URL:
    • Pull Master Branch:
      MDL-64206_master
    • Pull Master Diff URL:

      Description

      The image used in oauth 2 api in https://facebookbrand.com/wp-content/themes/fb-branding/prj-fb-branding/assets/images/fb-art.png gets now a 404, and is shown as a broken image if you use oauth2 login.

        Attachments

          Activity

            People

            Assignee:
            markn Mark Nelson
            Reporter:
            sergiocarrascomayans Sergio Carrasco Mayans
            Peer reviewer:
            Simey Lameze
            Integrator:
            Jun Pataleta
            Tester:
            Mathew May
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              5/Dec/18