Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64217

Connecting spinner icon showing in Clean on the Add to Contacts button

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Requirements

      1. This only needs to be tested on the Clean theme

      Regression

      Set up

      1. Log in as admin.
      2. Have a Moodle site with the theme set to clean.
      3. Clear all site/theme caches.
      4. Have a student enrolled in a course, with multiple activities due (eg chat and assignment).

      Test

      1. Log in as the student.
      2. Visit the dashboard, find the Timeline block.
        1. CONFIRM You can see the relevant icons next to each of the timeline items (eg chat/speech bubble icon next to chat, assignment/paper in hand icon next to the assignment).
        2. CONFIRM the additional black icons shown in Przemek's example in this issue are not visible.

      Test

      1. Create a site with 2 users both enrolled in the same course
      2. Log in as one of the students
      3. Go to the participant list in the course
      4. Click on the other user
      5. CONFIRM that you don't see the loading spinner in the "Add to contacts" button
      Show
      Requirements This only needs to be tested on the Clean theme Regression Set up Log in as admin. Have a Moodle site with the theme set to clean. Clear all site/theme caches. Have a student enrolled in a course, with multiple activities due (eg chat and assignment). Test Log in as the student. Visit the dashboard, find the Timeline block. CONFIRM You can see the relevant icons next to each of the timeline items (eg chat/speech bubble icon next to chat, assignment/paper in hand icon next to the assignment). CONFIRM the additional black icons shown in Przemek's example in this issue are not visible. Test Create a site with 2 users both enrolled in the same course Log in as one of the students Go to the participant list in the course Click on the other user CONFIRM that you don't see the loading spinner in the "Add to contacts" button
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull Master Branch:
      MDL-64217-master

      Description

      Tested $release = '3.6rc1 (Build: 20181125)' , $version = 2018112500.00; confirmed on qa.moodle.net master just now.

      1. Login as Teacher or manager (= how I tested it)
      2. Switch to Clean theme.
      3. Got to a course's participants list, pick a participant.
      4. Click on their name to bring up their course profile page.
      5. Notice the spinning wheel indicating connection process on top of the Add to Contacts button.
      6. This is to be seen on any user info page where this button can be found - issues discovered while testing MDLQA-12720.

      It looks serious to me. Could be a simple CSS problem. I did not get any errors, but when trying to refresh many pages on my localhost install, got memory errors like:

      Fatal error: Out of memory (allocated 14680064) (tried to allocate 1052672 bytes) in D:\Moodle36\server\moodle\cache\stores\file\lib.php on line 368
      Fatal error: Out of memory (allocated 8388608) (tried to allocate 32768 bytes) in D:\Moodle36\server\moodle\lib\tablelib.php on line 1663

       

      So I just wonder is this is not a leak of some type..

      Wasn't sure which components to choose..

       

      My screenshots:

       

       

       

       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ryanwyllie Ryan Wyllie
                Reporter:
                pmk Przemek Kaszubski
                Peer reviewer:
                Mihail Geshoski
                Integrator:
                Andrew Nicols
                Tester:
                Janelle Barcega
                Participants:
                Component watchers:
                Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón, Jake Dallimore, Jun Pataleta, Ryan Wyllie, Jake Dallimore, Jun Pataleta, Ryan Wyllie, Jake Dallimore, Jun Pataleta, Ryan Wyllie
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 20 minutes
                  20m