Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64224

core_message_get_conversation always returns isfavourite=false

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.6
    • Fix Version/s: 3.6
    • Component/s: Messages
    • Labels:

      Description

      While applying favourites in the mobile app I noticed that the WebService is always returning false for isfavourite, when it shouldn't.

      I debugged it and I've seen that, in core_message\api::get_conversation (used by the WebService), the context passed to favourite_exists is always 1 ($systemcontext). However, in the function set_favourite_conversation the context used is the conversation context. This causes the WS not to find the record and it thinks the conversation isn't favourite.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jaked Jake Dallimore
              Reporter:
              dpalou Dani Palou
              Peer reviewer:
              Adrian Greeve
              Integrator:
              Andrew Nicols
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Dec/18