Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64238

Timeline leaks Lesson & Quiz closing (or opening) dates to users suspended or not current in a course who have received a user override

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      PHPunit tests provided.

      Testing instructions:

      1. Log in as Teacher,
      2. create a course, enrol at least one student(S1).
      3. Create 2 Lessons and 2 Quizzes.
      4. Add closing dates(in the past) to Lesson 1 & Quiz 1.
      5. Add ONLY opening dates(in the past) to Lesson 2 & Quiz 2.
      6. Add user override dates for S1 for Lesson 1 & Quiz 1 (closing date overrides) and Lesson 2 & Quiz 2 (opening date overrides). Make sure all the override dates fall within Timeline's reach (no earlier than 14 days back).
      7. Log in as S1
      8. Add the timeline block, if not available
      9. Confirm you can see the lesson and quiz from #3
      10. Log back in as a teacher and suspend S1 from the course OR add a past enrolment date or a future start enrolment date to make them not current.
      11. Log in as S1
      12. Confirm you cannot view the lesson or quiz from #3 in the timeline block
      Show
      PHPunit tests provided. Testing instructions: Log in as Teacher, create a course, enrol at least one student(S1). Create 2 Lessons and 2 Quizzes. Add closing dates(in the past) to Lesson 1 & Quiz 1. Add ONLY opening dates(in the past) to Lesson 2 & Quiz 2. Add user override dates for S1 for Lesson 1 & Quiz 1 (closing date overrides) and Lesson 2 & Quiz 2 (opening date overrides). Make sure all the override dates fall within Timeline's reach (no earlier than 14 days back). Log in as S1 Add the timeline block, if not available Confirm you can see the lesson and quiz from #3 Log back in as a teacher and suspend S1 from the course OR add a past enrolment date or a future start enrolment date to make them not current. Log in as S1 Confirm you cannot  view the lesson or quiz from #3 in the timeline block
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-64238-master

      Description

      This was first briefly reported in MDL-64063 after it was closed.

      Scenario:

      1. Log in as Teacher into a course, enrol at least one student.
      2. Create 2 Lessons and 2 Quizzes.
      3. Add closing dates to Lesson 1 & Quiz 1.
      4. Add ONLY opening dates to Lesson 2 & Quiz 2.
      5. Add user override dates for the Student for Lesson 1 & Quiz 1 (closing date overrides) and Lesson 2 & Quiz 2 (opening date overrides). Make sure all the override dates fall within Timeline's reach (no earlier than 14 days back).
      6. Suspend the Student in the course OR add them a past enrolment date or a future start enrolment date to make them Not current.
      7. Log in as the student and notice that their Timeline will display all the Lesson & Quiz override dates, even though the student cannot access them in view of being suspended / not current in the course.

      The problem does NOT concern Assignment. The problem does not concern group overrides - according my tests first reported in MDL-64063.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              peterdias Peter Dias
              Reporter:
              pmk Przemek Kaszubski
              Peer reviewer:
              Tim Hunt
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Mar/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 40 minutes
                  40m