Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64245

Multiple small fixes to messaging appearance (take#2)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6
    • Fix Version/s: 3.6
    • Component/s: Messages, Themes
    • Labels:
    • Testing Instructions:
      Hide

      Please test these UI changes on:

      1. Clean and Boost themes
      2. Supported browsers
      3. LTR and RTL display
      Setup
      1. Log in as an admin
      2. Create a course C1
      3. Enrol students s1, s2 to C1
      4. Create group g1 and enable group messaging
      5. Add s1 and s2 to g1
      Sender and last message - Private conversation
      1. Log in as s1.
      2. Search and add s2 as your contact.
      3. On another browser session (e.g. incognito mode), log in as s2 and accept s2's contact request.
      4. Star s2 and g1.
      5. Place s1 and s2's browsers side by side.
      6. As s1, open the messaging pane and open the conversation with s2.
      7. As s2, open the messaging pane and open the conversation with s1.
      8. On s1's browser, send a long message to s2 (maybe at least 100 characters). Make sure the message contains new lines, html (e.g. <strong>COOL!</strong>), single/double quotes, ampersands, etc.
      9. Confirm that the message is successfully sent.
      10. Go back to the conversation list.
      11. Confirm that the preview of the last message for your conversation with s2 is shown as "You: LAST_MESSAGE".
      12. COnfirm that the preview message is shown in one line and is truncated.
      13. Reload the page and open the message pane again.
      14. Confirm that the preview of the last message for your conversation with s2 is still shown as "You: LAST_MESSAGE".
      15. COnfirm that the preview message is shown in one line and is still truncated.
      16. On s2's browser, confirm that you receive the message and is rendered according to what the s1 sent.
      17. Go back to the conversations list.
      18. Confirm that the preview of the last message for your conversation with s2 is shown as "LAST_MESSAGE".
      19. Confirm that the preview message is shown in one line and is truncated.
      20. Reload the page and open the message pane again.
      21. Confirm that the preview of the last message for your conversation with s2 is still shown as "LAST_MESSAGE".
      22. Confirm that the preview message is shown in one line and is still truncated.
      Sender and last message - Group conversation
      1. Log in as s1.
      2. On another browser session (e.g. incognito mode), log in as s2.
      3. Place s1 and s2's browsers side by side.
      4. As s1, open the messaging pane and open the group conversation for g1.
      5. As s2, open the messaging pane and open the group conversation for g1.
      6. On s1's browser, send a long message to the group message (maybe at least 100 characters). Make sure the message contains new lines, html (e.g. <strong>COOL!</strong>), single/double quotes, ampersands, etc.
      7. Confirm that the message is successfully sent.
      8. Go back to the conversation list.
      9. Confirm that the preview of the last message for your conversation for g1 is shown as "You: LAST_MESSAGE".
      10. Confirm that the preview message is shown in one line and is truncated.
      11. Reload the page and open the message pane again.
      12. Confirm that the preview of the last message for your conversation for g1 is still shown as "You: LAST_MESSAGE".
      13. COnfirm that the preview message is shown in one line and is still truncated.
      14. On s2's browser, confirm that you receive the message and is rendered according to what the s1 sent.
      15. Go back to the conversations list.
      16. Confirm that the preview of the last message for your conversation for g1 is shown as "S1's_NAME: LAST_MESSAGE".
      17. Confirm that the preview message is shown in one line and is truncated.
      18. Reload the page and open the message pane again.
      19. Confirm that the preview of the last message for your conversation for g1 is still shown as "S1's_NAME: LAST_MESSAGE".
      20. Confirm that the preview message is shown in one line and is still truncated.
      Conversation with lots of messages
      1. Create a conversation between two users (s1 and s2)
      2. Add s2 as a contact to s1
      3. Send messages to the conversation as s1 (over 100 messages)
      4. Reload the page and open the message drawer.
      5. View the contacts page
      6. Select the user s2 to go to the conversation between s1 and s2
      7. Confirm that the conversation loads without showing an exception modal.
        • Note: accessing the conversation this way may not scroll you to the most recent message (bottom) automatically. This is a separate issue that can be fixed after 3.6 release.
      8. Scroll up to the top of the conversation to load the earlier messages
      9. CONFIRM that the earlier messages load correctly in the page
      10. Reload the page
      11. Open the message drawer
      12. Click on the conversation with s2 from the main view (it should be under the "Starred" section from the previous test)
      13. CONFIRM that the conversation loads without showing an exception modal.
      14. Scroll up to the top of the conversation to load the earlier messages
      15. CONFIRM that the earlier messages load correctly in the page
      Contacts and contact requests (Test on Safari 10 and latest Safari versions)
      1. Add another user s3.
      2. Enrol user s3 in course C1
      3. As s3, add s1 as a contact.
      4. Back on s1's browser window, check your Contacts list.
      5. Confirm that you see s2 there.
      6. Click on the Requests list.
      7. Confirm that you see s3 there.
      Show
      Please test these UI changes on: Clean and Boost themes Supported browsers LTR and RTL display Setup Log in as an admin Create a course C1 Enrol students s1, s2 to C1 Create group g1 and enable group messaging Add s1 and s2 to g1 Sender and last message - Private conversation Log in as s1. Search and add s2 as your contact. On another browser session (e.g. incognito mode), log in as s2 and accept s2's contact request. Star s2 and g1. Place s1 and s2's browsers side by side. As s1, open the messaging pane and open the conversation with s2. As s2, open the messaging pane and open the conversation with s1. On s1's browser, send a long message to s2 (maybe at least 100 characters). Make sure the message contains new lines, html (e.g. <strong>COOL!</strong> ), single/double quotes, ampersands, etc. Confirm that the message is successfully sent. Go back to the conversation list. Confirm that the preview of the last message for your conversation with s2 is shown as " You: LAST_MESSAGE ". COnfirm that the preview message is shown in one line and is truncated. Reload the page and open the message pane again. Confirm that the preview of the last message for your conversation with s2 is still shown as " You: LAST_MESSAGE ". COnfirm that the preview message is shown in one line and is still truncated. On s2's browser, confirm that you receive the message and is rendered according to what the s1 sent. Go back to the conversations list. Confirm that the preview of the last message for your conversation with s2 is shown as " LAST_MESSAGE ". Confirm that the preview message is shown in one line and is truncated. Reload the page and open the message pane again. Confirm that the preview of the last message for your conversation with s2 is still shown as " LAST_MESSAGE ". Confirm that the preview message is shown in one line and is still truncated. Sender and last message - Group conversation Log in as s1. On another browser session (e.g. incognito mode), log in as s2. Place s1 and s2's browsers side by side. As s1, open the messaging pane and open the group conversation for g1. As s2, open the messaging pane and open the group conversation for g1. On s1's browser, send a long message to the group message (maybe at least 100 characters). Make sure the message contains new lines, html (e.g. <strong>COOL!</strong> ), single/double quotes, ampersands, etc. Confirm that the message is successfully sent. Go back to the conversation list. Confirm that the preview of the last message for your conversation for g1 is shown as " You: LAST_MESSAGE ". Confirm that the preview message is shown in one line and is truncated. Reload the page and open the message pane again. Confirm that the preview of the last message for your conversation for g1 is still shown as " You: LAST_MESSAGE ". COnfirm that the preview message is shown in one line and is still truncated. On s2's browser, confirm that you receive the message and is rendered according to what the s1 sent. Go back to the conversations list. Confirm that the preview of the last message for your conversation for g1 is shown as " S1's_NAME: LAST_MESSAGE ". Confirm that the preview message is shown in one line and is truncated. Reload the page and open the message pane again. Confirm that the preview of the last message for your conversation for g1 is still shown as " S1's_NAME: LAST_MESSAGE ". Confirm that the preview message is shown in one line and is still truncated. Conversation with lots of messages Create a conversation between two users (s1 and s2) Add s2 as a contact to s1 Send messages to the conversation as s1 (over 100 messages) Reload the page and open the message drawer. View the contacts page Select the user s2 to go to the conversation between s1 and s2 Confirm that the conversation loads without showing an exception modal. Note: accessing the conversation this way may not scroll you to the most recent message (bottom) automatically. This is a separate issue that can be fixed after 3.6 release. Scroll up to the top of the conversation to load the earlier messages CONFIRM that the earlier messages load correctly in the page Reload the page Open the message drawer Click on the conversation with s2 from the main view (it should be under the "Starred" section from the previous test) CONFIRM that the conversation loads without showing an exception modal. Scroll up to the top of the conversation to load the earlier messages CONFIRM that the earlier messages load correctly in the page Contacts and contact requests (Test on Safari 10 and latest Safari versions) Add another user s3. Enrol user s3 in course C1 As s3, add s1 as a contact. Back on s1's browser window, check your Contacts list. Confirm that you see s2 there. Click on the Requests list. Confirm that you see s3 there.
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull Master Branch:
      MDL-64245-master

      Description

      This is a continuation of MDL-64099 that was exceptionally closed with some issues still to be fixed.

      The reason for the exceptional handling is that the original issue was blocking continuous integration and rolling and various release-related tasks. Hence, here we are.

      So this issue is about to fix and test all the remaining issues from MDL-64099, namely:

      A) The Safari 10 no contacts problem.
      B) Problems on IE browsers, clean theme, scroll bars overlapping the badges.
      C) Firefox, IE11, Edge, boost theme, scroll bar not visible.
      D) The lastmessage and \r\n problem, some work ongoing from Jun @ template level.

      (feel free to add more numbered problems if there is any missing)

        Attachments

        1. double scrollbar.png
          double scrollbar.png
          79 kB
        2. lazyload.gif
          lazyload.gif
          5.47 MB
        3. MDL-64245_LTR.PNG
          MDL-64245_LTR.PNG
          221 kB
        4. MDL-64245_RTL.PNG
          MDL-64245_RTL.PNG
          195 kB
        5. MDL-64245_safari.JPG
          MDL-64245_safari.JPG
          68 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours
                  4h