Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64267

Double scrollbars in a conversation on Clean theme

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Please test on both all themes(clean and boost for 3.6, classic and boost for master)

      If you are using macos for testing make sure your setup is configured to show scrollbars. (In macos: System preferences -> general > Show scrollbars : Always)

      Setup your test environment.

      1. Log in as Admin
      2. Create users s1, s2
      3. Create course C1
      4. Enrol users s1 and s2 in course C1

      Test scrolling behaviour

      1. Login as user s1
      2. Open the message drawer and search for user s2
      3. Click on the s2 username
      4. Click the top right menu and choose add as contact
      5. Send user s2 about 20 messages
      6. Verify you only see one scrollbar within the message drawer. Note there may be a second scrollbar for the full page itself.
      7. Verify you see the "Contact request sent" message positioned sticky at the top of the message container
      Show
      Please test on both all themes(clean and boost for 3.6, classic and boost for master) If you are using macos for testing make sure your setup is configured to show scrollbars. (In macos: System preferences -> general > Show scrollbars : Always) Setup your test environment. Log in as Admin Create users s1, s2 Create course C1 Enrol users s1 and s2 in course C1 Test scrolling behaviour Login as user s1 Open the message drawer and search for user s2 Click on the s2 username Click the top right menu and choose add as contact Send user s2 about 20 messages Verify you only see one scrollbar within the message drawer. Note there may be a second scrollbar for the full page itself. Verify you see the "Contact request sent" message positioned sticky at the top of the message container
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.6 Branch:
    • Pull Master Branch:
      MDL-64267-master

      Description

      Again from Bas:

      On theme Clean there is an extra scrollbar on the div with class .content-message-container. It seems to be related to the added pb-2, I am not sure if that needs a new tracker issue.

        Attachments

        1. double scrollbar.png
          double scrollbar.png
          79 kB
        2. double scrollbar boost.png
          double scrollbar boost.png
          33 kB
        3. patch-MDL_64267.diff
          1 kB
        4. scroll_previous_behaviour.png
          scroll_previous_behaviour.png
          31 kB
        5. scroll_new_behaviour1.png
          scroll_new_behaviour1.png
          28 kB
        6. scroll_new_behaviour2.png
          scroll_new_behaviour2.png
          29 kB
        7. position-sticky.png
          position-sticky.png
          118 kB
        8. integration36.jpg
          integration36.jpg
          15 kB
        9. integration36.mp4
          687 kB
        10. stable_36.jpg
          stable_36.jpg
          19 kB
        11. stable_master.jpg
          stable_master.jpg
          7 kB
        12. MDL-64267.jpg
          MDL-64267.jpg
          17 kB
        13. MDL-64267_integration36.jpg
          MDL-64267_integration36.jpg
          18 kB

          Issue Links

            Activity

              People

              • Votes:
                6 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 6 hours, 16 minutes
                  6h 16m