[MDL-64274] deleteMessages in message_repository.js doesn't return a promise - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Note: Make sure to purge your caches before starting the test.

Create a site with two users (s1 and s2) in the same course

Log in as s1

Search for s2

Send s2 a few messages

Click on one (or more but not all) messages to select them

Click the trash icon at the bottom to delete the selected messages

CONFIRM that the messages are removed

Reload the page

Open the messaging and view that conversation again

CONFIRM that the messages you deleted are not shown
Show
Note: Make sure to purge your caches before starting the test. Create a site with two users (s1 and s2) in the same course Log in as s1 Search for s2 Send s2 a few messages Click on one (or more but not all) messages to select them Click the trash icon at the bottom to delete the selected messages CONFIRM that the messages are removed Reload the page Open the messaging and view that conversation again CONFIRM that the messages you deleted are not shown
Affected Branches:
MOODLE_36_STABLE
Fixed Branches:
MOODLE_36_STABLE
Epic Link:
Group messaging follow-ups
Pull from Repository:
git://github.com/ryanwyllie/moodle.git
Pull Master Branch:
~~MDL-64274~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...ryanwyllie:MDL-64274-master

The deleteMessages function in message/amd/src/message_repository.js doesn't return a single promise, instead it returns an array of promises.

It should return a single promise.

Estimated:

Remaining:

Logged:

15m