Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64274

deleteMessages in message_repository.js doesn't return a promise

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6
    • Fix Version/s: 3.6.2
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide

      Note: Make sure to purge your caches before starting the test.

      1. Create a site with two users (s1 and s2) in the same course
      2. Log in as s1
      3. Search for s2
      4. Send s2 a few messages
      5. Click on one (or more but not all) messages to select them
      6. Click the trash icon at the bottom to delete the selected messages
      7. CONFIRM that the messages are removed
      8. Reload the page
      9. Open the messaging and view that conversation again
      10. CONFIRM that the messages you deleted are not shown
      Show
      Note: Make sure to purge your caches before starting the test. Create a site with two users (s1 and s2) in the same course Log in as s1 Search for s2 Send s2 a few messages Click on one (or more but not all) messages to select them Click the trash icon at the bottom to delete the selected messages CONFIRM that the messages are removed Reload the page Open the messaging and view that conversation again CONFIRM that the messages you deleted are not shown
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-64274-master
    • Pull Master Diff URL:

      Description

      The deleteMessages function in message/amd/src/message_repository.js doesn't return a single promise, instead it returns an array of promises.

      It should return a single promise.

        Attachments

          Activity

            People

            Assignee:
            ryanwyllie Ryan Wyllie
            Reporter:
            ryanwyllie Ryan Wyllie
            Peer reviewer:
            Carlos Escobedo Carlos Escobedo
            Integrator:
            Jun Pataleta Jun Pataleta
            Tester:
            Janelle Barcega Janelle Barcega
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Jan/19

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 15 minutes
                15m