[MDL-64283] competency data generator increments the frameworkcount too much - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.5.3, 3.6.1, 3.7
Fix Version/s: 3.5.4, 3.6.2
Component/s: Competencies
Labels:
- ci
- triaged

Testing Instructions:

Hide

This only affects unit tests so running unit tests covers this. "–filter=competency" is even quicker!

Show
This only affects unit tests so running unit tests covers this. "–filter=competency" is even quicker!
Affected Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE
Pull from Repository:
git://github.com/damyon/moodle.git
Pull Master Branch:
~~MDL-64283~~-master
Pull Master Diff URL:
https://github.com/damyon/moodle/compare/0225ad42ea...MDL-64283-master

Description

https://github.com/moodle/moodle/blob/master/competency/tests/generator/lib.php#L98:L99

This should only happen in create_framework, not when we create a competency.

Attachments

Activity

People

Assignee:: Damyon Wiese

Reporter:: Damyon Wiese

Peer reviewer:: Ruslan Kabalin

Integrator:: Jun Pataleta

Tester:: CiBoT

Participants:: CiBoT, Damyon Wiese, Jake Dallimore, Jun Pataleta, Ruslan Kabalin

Component watchers:: Jean-Philippe Gaudreau, Steve Massicotte, Serge Gauthier, Issam Taboubi, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 30/Nov/18 9:27 AM

Updated:: 10/Dec/18 8:46 AM

Resolved:: 10/Dec/18 8:46 AM

Fix Release Date:: 14/Jan/19