Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 3.5.3, 3.6
-
Component/s: Backup: IMS-CC
-
Labels:
-
Testing Instructions:
- Edit config.php and set $CFG->tempdir to something other than the default location, (e.g. /[path/to/the/folder/that/contains/moodledata]/moodletemp/). Make sure this folder exists.
- Log in as an admin and go to "Site administration / Courses / Restore course"
- Restore the attached ims-common-cartridge-test-export.imscc
to a new course. - Confirm that you are able to successfully restore this backup file to a course.
Edit config.php and set $CFG->tempdir to something other than the default location, (e.g. / [path/to/the/folder/that/contains/moodledata] /moodletemp/). Make sure this folder exists. Log in as an admin and go to " Site administration / Courses / Restore course " Restore the attached ims-common-cartridge-test-export.imscc to a new course. Confirm that you are able to successfully restore this backup file to a course. -
Difficulty:Easy
-
Affected Branches:MOODLE_35_STABLE, MOODLE_36_STABLE
-
Fixed Branches:MOODLE_35_STABLE, MOODLE_36_STABLE
-
Pull from Repository:
-
Pull Master Branch:master-
MDL-64290-imscc-restore-temp-dir
Description
If a Moodle site has set $CFG->tempdir set to something other than the default location, restoring an imscc file fails with error "The selected file is not a valid Moodle backup file and can't be restored." This is because in backup/converter/imscc1/lib.php and backup/converter/imscc11/lib.php the path is hard coded to
$CFG->dataroot . '/temp/backup/' . $tempdir;
Steps to reproduce:
- Set Set $CFG->tempdir to something other than the default location, such as, /moodletemp/
- Create an imscc backup on the Moodle site or upload an already created one.
- Attempt to restore the imscc file.
I will create fix on a branch in github.
