-
Bug
-
Resolution: Fixed
-
Minor
-
3.6, 3.7
-
MOODLE_36_STABLE, MOODLE_37_STABLE
-
MOODLE_36_STABLE
-
(NOTE: Before 3.2, the comment was "// Moodle v3.1.0 release upgrade line." and it was changed to have "Automatically generated..." for v3.2.0 and upwards.)
In order to have it properly detected for the future it would be great to add to all the upgrade.php scripts some lines like these:
// Automatically generated Moodle v3.6.0 release upgrade line.
|
// Put any upgrade step following this.
|
exactly before the "return true;" present in all the scripts.
I think it's ok to do that both in the 36_STABLE and master branches, so they will allow quickly find where 3.6.0 started and act once we decide future requirements.
The change can be performed globally with:
#!/bin/bash
|
export rel="3.6.0" && find . -name upgrade.php | \
|
xargs grep -l 'function.*xmldb_.*_upgrade' | \
|
grep '/db/' | \
|
xargs grep -L "Automatically generated Moodle v${rel} release upgrade" | \
|
xargs perl -p -i -e 's@( *)(return true;)@\1// Automatically generated Moodle v$ENV{rel} release upgrade line.\n\1// Put any upgrade step following this.\n\n\1\2@s'
|
Command to detect all the upgrade.php files not having those lines:
find . -name upgrade.php | xargs grep -l 'function.*xmldb_.*_upgrade' | grep '/db/' | xargs grep -L 'Automatically generated Moodle v3.6.0 release upgrade'
|
Commands to detect that we have not added the lines to incorrect files:
grep -lr 'Automatically generated Moodle v3.6.0 release upgrade' * | grep -v '/db/'
|
grep -lr 'Automatically generated Moodle v3.6.0 release upgrade' * | xargs grep -L 'function.*xmldb_.*_upgrade'
|
Command to detect if the lines have been added after a post-release upgrade step. If there are upgrade steps found verify that all them were already there the day of the release and have not been introduced later (you can look for differences between the release v3.6.0 and current master to verify that)
export rel="3.6.0" && export ver="201812" &&
|
find . -name upgrade.php | \
|
xargs grep -B25 "Automatically generated Moodle v${rel} release upgrade" | \
|
grep "upgrade_.*_savepoint.*${ver}"
|
Ciao