Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64320

Indicators with discrete values are broken

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.5.3, 3.6, 3.7
    • Fix Version/s: 3.5.5, 3.6.3
    • Component/s: Analytics
    • Labels:
    • Testing Instructions:
      Hide
      1. Install https://github.com/dmonllao/moodle-local_latesubmissions
      2. Log in as admin and go to to site admin > analytics > analytics settings
      3. Add "Two days before the end" to the list of enabled time splitting methods
      4. Now go to site admin > analytics > analytics models and select Actions > Edit for "Students at risk of missing assignment due dates"
      5. Add the indicator "Activity weight in the gradebook" to the model if it is not already there and save changes
      6. Use an existing course in your site with enrolments
      7. Set the course start date to 2 weeks ago
      8. Create 2 assignments with a due date (a few days after the course start date)
      9. Go to CLI and run "php admin/tool/analytics/cli/evaluate_model.php"
      10. You SHOULD see a list of models, "Students at risk of missing assignment due dates" SHOULD be one of these models. Remember its id. You will need it for the next step
      11. Again in CLI run "php admin/tool/analytics/cli/evaluate_model.php --modelid=YEAH --timesplitting='\local_latesubmissions\analytics\time_splitting\really_close_to_deadline'". Where YEAH is the modelid
      12. The process SHOULD finish without any PHP fatal error nor exception. If there is a problem you will probably get the locking exception that masks the real problem
      Show
      Install https://github.com/dmonllao/moodle-local_latesubmissions Log in as admin and go to to site admin > analytics > analytics settings Add "Two days before the end" to the list of enabled time splitting methods Now go to site admin > analytics > analytics models and select Actions > Edit for "Students at risk of missing assignment due dates" Add the indicator "Activity weight in the gradebook" to the model if it is not already there and save changes Use an existing course in your site with enrolments Set the course start date to 2 weeks ago Create 2 assignments with a due date (a few days after the course start date) Go to CLI and run "php admin/tool/analytics/cli/evaluate_model.php" You SHOULD see a list of models, "Students at risk of missing assignment due dates" SHOULD be one of these models. Remember its id. You will need it for the next step Again in CLI run "php admin/tool/analytics/cli/evaluate_model.php --modelid=YEAH --timesplitting='\local_latesubmissions\analytics\time_splitting\really_close_to_deadline'". Where YEAH is the modelid The process SHOULD finish without any PHP fatal error nor exception. If there is a problem you will probably get the locking exception that masks the real problem
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-64320_master

      Description

      Discrete indicators return classes, not a value between -1 and 1. We should add a indicator-type-dependant method to validate the values returned by indicators.

        Attachments

          Activity

            People

            Assignee:
            dmonllao David Monllaó
            Reporter:
            dmonllao David Monllaó
            Peer reviewer:
            Víctor Déniz Falcón
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Shamim Rezaie
            Participants:
            Component watchers:
            Elizabeth Dalton, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Mar/19