Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64331

Changes in modal form are lost when user accidentally clicks outside of a modal

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      AMD modal that doesn't contain form tags
      1. Login as site admin
      2. Go to "Site administration / Users / Privacy and policies / Data requests"
      3. Create a data request for a user.
      4. Back on the Data requests page view the request.
      5. Click anywhere outside the modal dialogue.
      6. Confirm that the dialogue closes.
      AMD modal that contains form tags
      1. Open the calendar.
      2. Click "New event"
      3. Click anywhere outside the modal dialogue.
      4. Confirm that the dialogue does not close.
      YUI modal that contains form tags
      1. Go to "Site administration / Appearance / Manage tags"
      2. Click "Add tag collection"
      3. Click anywhere outside the modal dialogue.
      4. Confirm that the dialogue does not close.
      5. Enter a name for the tag collection and click "Create"
      6. Click on the link for the tag collection.
      7. Click "Add standard tags"
      8. Enter a tag.
      9. Click anywhere outside the modal dialogue.
      10. Confirm that the dialogue does not close.
      YUI modal that doesn't contain form tags
      1. Continuing from the previous section, click "Continue".
      2. Click on the delete icon for the tag that you created.
      3. Click anywhere outside the confirmation modal dialogue.
      4. Confirm that the dialogue closes.
      5. Click on "Combine seleced"
      6. Click anywhere outside the Combine selected modal dialogue.
      7. Confirm that the dialogue closes.
      Show
      AMD modal that doesn't contain form tags Login as site admin Go to " Site administration / Users / Privacy and policies / Data requests " Create a data request for a user. Back on the Data requests page view the request. Click anywhere outside the modal dialogue. Confirm that the dialogue closes. AMD modal that contains form tags Open the calendar. Click " New event " Click anywhere outside the modal dialogue. Confirm that the dialogue does not close. YUI modal that contains form tags Go to " Site administration / Appearance / Manage tags " Click " Add tag collection " Click anywhere outside the modal dialogue. Confirm that the dialogue does not close. Enter a name for the tag collection and click " Create " Click on the link for the tag collection. Click " Add standard tags " Enter a tag. Click anywhere outside the modal dialogue. Confirm that the dialogue does not close. YUI modal that doesn't contain form tags Continuing from the previous section, click " Continue ". Click on the delete icon for the tag that you created. Click anywhere outside the confirmation modal dialogue. Confirm that the dialogue closes. Click on " Combine seleced " Click anywhere outside the Combine selected modal dialogue. Confirm that the dialogue closes.
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.6 Branch:
    • Pull Master Branch:
      MDL-64331-master
    • Sprint:
      Workplace for Moodle 3.7

      Description

      This is a regression from MDL-60207
      When a form is displayed in a modal dialogue, user made some changes to it and then accidentally clicked outside of the modal the dialogue is hidden and the form changes are lost.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                4 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 6 hours, 30 minutes
                  6h 30m