Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64333

Message migration message never shown

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6
    • Fix Version/s: 3.6.3
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide

      Note: Test on Clean and Boost

      1. Install a fresh 3.4 test site with at least three users (A, B and C).
        • E.g. using mdk:
          1. Uninstall your current site: mdk uninstall
          2. Checkout Moodle 3.4: git checkout v3.4.0
          3. Cleanup folders that may have been left by plugins that were installed in 3.5 and up: "rm -rf blocks/timeline blocks/recentlyaccesseditems repository/nextcloud mod/lti/service/gradebookservices admin/tool/dataprivacy admin/tool/policy"
          4. Install: mdk install -r users
      2. Log in as A.
      3. Click on the messaging icon in the top right.
      4. Click on 'See all'.
      5. Search for and send a message to user B.
      6. Log in as C.
      7. Click on the messaging icon in the top right.
      8. Click on 'See all'.
      9. Search for and send a message to user B.
      10. Log out.
      11. Upgrade your site.
        • If testing on master: git checkout master, then proceed with the upgrade
        • If testing on 36: git checkout MOODLE_36_STABLE, then proceed with the upgrade
      12. Log in as user A.
      13. Confirm on the messaging drawer there is a message saying that your messages have not been migrated.
      14. Run the cron.
      15. Confirm this message has gone and you can see your conversation with B.
      16. Log in as B.
      17. Confirm on the messaging drawer there is a message saying that your messages have not been migrated and you can see the conversation with A.
      18. Run the cron.
      19. Confirm this message has gone and you can see your conversation with A and C.
      Show
      Note: Test on Clean and Boost Install a fresh 3.4 test site with at least three users (A, B and C). E.g. using mdk: Uninstall your current site: mdk uninstall Checkout Moodle 3.4: git checkout v3.4.0 Cleanup folders that may have been left by plugins that were installed in 3.5 and up: " rm -rf blocks/timeline blocks/recentlyaccesseditems repository/nextcloud mod/lti/service/gradebookservices admin/tool/dataprivacy admin/tool/policy " Install: mdk install -r users Log in as A. Click on the messaging icon in the top right. Click on 'See all'. Search for and send a message to user B. Log in as C. Click on the messaging icon in the top right. Click on 'See all'. Search for and send a message to user B. Log out. Upgrade your site. If testing on master: git checkout master , then proceed with the upgrade If testing on 36: git checkout MOODLE_36_STABLE , then proceed with the upgrade Log in as user A. Confirm on the messaging drawer there is a message saying that your messages have not been migrated. Run the cron. Confirm this message has gone and you can see your conversation with B. Log in as B. Confirm on the messaging drawer there is a message saying that your messages have not been migrated and you can see the conversation with A. Run the cron. Confirm this message has gone and you can see your conversation with A and C.
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-64333_master

      Description

      In 3.5 we migrated data from an old table structure to a new table structure via an ad-hoc task that would be queued whenever a user logged in. If they visited message/index.php before the task had finished the migration they would be shown a message letting them know the messages were unavailable for now - preventing them from freaking out. This does not happen in the new UI.

      See MDL-61255.

        Attachments

        1. moodle-36.jpg
          moodle-36.jpg
          41 kB
        2. moodle-master.jpg
          moodle-master.jpg
          41 kB
        3. No messages.png
          No messages.png
          96 kB
        4. private section.jpg.png
          private section.jpg.png
          22 kB
        5. screenshot-1.png
          screenshot-1.png
          27 kB
        6. Screen Shot 2019-02-26 at 11.52.06 am.png
          Screen Shot 2019-02-26 at 11.52.06 am.png
          39 kB
        7. With new messages.png
          With new messages.png
          162 kB

          Issue Links

            Activity

              People

              Assignee:
              markn Mark Nelson
              Reporter:
              markn Mark Nelson
              Peer reviewer:
              Carlos Escobedo
              Integrator:
              Jun Pataleta
              Tester:
              Bas Brands
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Mar/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 1 day
                  1d
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 30 minutes Time Not Required
                  4h 30m