Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64336

When an assignment is frozen students cannot see their submission

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Waiting for peer review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.6.1
    • Fix Version/s: None
    • Component/s: Assignment, Roles / Access
    • Labels:
    • Testing Instructions:
      Hide

      Setup

      1. Create a Course
      2. Create an Assignment in Course using the following settings:
        1. Allow submissions from is set to be in the past
        2. Due date is set to be in the future
        3. Submission types: Online text
        4. Feedback types: Feedback comments
        5. Require students to click the submit button: Yes
        6. Attempts reopened: Manually
      3. Create users Anne Student, Bob Student, Claire Student, David Student, Felicity Student and George Student enrol them as a student on Course
      4. Create user Emma Teacher and enrol them as a teacher on Course
      5. Enable Mobile Web services in the site

      Adding data to the assignment

      1. Login as Anne Student
        1. Navigate to Assignment
        2. Press the Add submission button
        3. Enter some text in the Online text box.
        4. Press Save changes
        5. Add a comment to the Submission comments
        6. Press Submit assignment
      2. Login as Bob Student
        1. Navigate to Assignment
        2. Press the Add submission button
        3. Enter some text in the Online text box.
        4. Press Save changes
        5. Press Submit assignment
      3. Login as David Student
        1. Navigate to Assignment
        2. Press the Add submission button
        3. Enter some text in the Online text box.
        4. Press Save changes
        5. Press Submit assignment
      4. Login as Felicity Student
        1. Navigate to Assignment
        2. Press the Add submission button
        3. Enter some text in the Online text box.
        4. Press Save changes
      5. Login as George Student
        1. Navigate to Assignment
      6. Login as Emma Teacher
        1. Navigate to Assignment
        2. Press View all submissions
        3. Press the Grade button for Anne Student
        4. Press Save changes
        5. For David Student in the Edit action menu select Allow another attempt

      Tests for removing assign:submit capability

      Preparation

      1. Login as Admin
      2. Navigate to Assignment
      3. Open the action menu and select Permissions and confirm the action
      4. In the Filter enter assign:submit
      5. Click the plus symbol in the prohibit column for the Submit assignment row
      6. Press the Student button in the Prohibit role dialogue box
      7. Confirm that Student now appears in the Prohibited column of the Submit assignment role

      Students can view their submissions

      1. Login as Anne Student
        1. Navigate to Assignment
        2. Verify that the Grading summary is not visible to the user
        3. Verify that the Submission status is visible to the user
        4. Verify that the Edit submission button is not present
      2. Login as Bob Student
        1. Navigate to Assignment
        2. Verify that the Grading summary is visible to the user
        3. Verify that the Submission status is visible to the user
        4. Verify that the Add submission button is not present
      3. Login as Claire Student
        1. Navigate to Assignment
        2. Verify that the Grading summary is not visible to the user
        3. Verify that the Submission status is not visible to the user
      4. Login as David Student
        1. Navigate to Assignment
        2. Verify that the Grading summary is visible to the user
        3. Verify that the Submission status is visible to the user
        4. Verify that the Add submission button is not present
        5. Verify that the Add a new attempt based on previous submission button is not present
        6. Verify that the Add a new attempt button is not present
      5. Login as Felicity Student
        1. Navigate to Assignment
        2. Verify that the Grading summary is visible to the user
        3. Verify that the Submission status is visible to the user
        4. Verify that the Add submission button is not present
        5. Verify that the Edit submission button is not present
        6. Verify that the Remove submission button is not present
        7. Verify that the Submit assignment button is not present
      6. Login as George Student
        1. Navigate to Assignment
        2. Verify that the Grading summary is not visible to the user
        3. Verify that the Submission status is not visible to the user

      Teacher can see users who have submitted

      1. Login as Emma Teacher
      2. Navigate to Assignment
      3. Press View all submissions
      4. Verify that the following students are in the list:
        • Anne Student
        • Bob Student
        • David Student
        • Felicity Student
      5. Verify that the following students do not appear in the list:
        • Claire Student
        • George Student

      Preparation for the following tests

      1. Login as Admin
      2. Navigate to Assignment
      3. Open the action menu and select Permissions and confirm the action
      4. In the Filter enter assign:submit
      5. Press the Delete icon next to student
      6. Confirm that Student now appears in the Roles with permission column of the Submit assignment role

      Tests for context freezing

      Preparation

      1. Login as Admin
      2. Navigate to "Site administration | Development | Experimental | Experimental settings" and enable "Context freezing (contextlocking)"
      3. Navigate to "Site administration | Mobile app |Mobile settings" and enable "Enable web services for mobile devices"
      4. Navigate to Assignment
      5. Open the action menu and select Freeze this context and confirm the action

      Users can see submissions when frozen

      1. Login as Anne Student
        1. Navigate to Assignment
        2. Verify that the Grading summary is not visible to the user
        3. Verify that the Submission status is visible to the user
        4. Verify that the Submission comments can be viewed, but that the new comment area is not present
        5. Verify that the Edit submission button is not present
      2. Login as Bob Student
        1. Navigate to Assignment
        2. Verify that the Grading summary is visible to the user
        3. Verify that the Submission status is visible to the user
        4. Verify that the Add submission button is not present
      3. Login as Claire Student
        1. Navigate to Assignment
        2. Verify that the Grading summary is not visible to the user
        3. Verify that the Submission status is not visible to the user
      4. Login as David Student
        1. Navigate to Assignment
        2. Verify that the Grading summary is visible to the user
        3. Verify that the Submission status is visible to the user
        4. Verify that the Add submission button is not present
        5. Verify that the Add a new attempt based on previous submission button is not present
        6. Verify that the Add a new attempt button is not present
      5. Login as Felicity Student
        1. Navigate to Assignment
        2. Verify that the Grading summary is visible to the user
        3. Verify that the Submission status is visible to the user
        4. Verify that the Add submission button is not present
        5. Verify that the Edit submission button is not present
        6. Verify that the Remove submission button is not present
        7. Verify that the Submit assignment button is not present
      6. Login as George Student
        1. Navigate to Assignment
        2. Verify that the Grading summary is not visible to the user
        3. Verify that the Submission status is not visible to the user

      Teacher can see users who have submitted

      1. Login as Emma Teacher
      2. Navigate to Assignment
      3. Press View all submissions
      4. Verify that you can see the Grade and Final grade columns in the table
      5. Verify that you can see a submission for Anne Student and that
        1. the submission made can be viewed in the Online text column
      6. Verify that you can see a submission for Bob Student and that
        1. the submission made can be viewed in the Online text column
        2. the comments you made are visible in the Feedback comments column
        3. the grade you gave them displays in the Grade and Final grade columns
      7. Verify that you can see a submission for David Student and that
        1. the submission made can be viewed in the Online text column
      8. Verify that you can see a submission for Felicity Student and that
        1. the submission made can be viewed in the Online text column

      Note: Claire Student and George Student should either both appear or both not appear in the list depending on the status of MDL-64410. This test should fail if only one of them appears in the list.

      Users can see submissions when frozen in the Moodle App

      1. Login to the site on the Mobile App as Anne Student
        1. Navigate to Assignment
        2. Verify that the no tabs are visible to the user
        3. Verify that details of the submission are visible to the user
        4. Verify that the Edit submission button is not present
      2. Login to the site on the Mobile App as Bob Student
        1. Navigate to Assignment
        2. Verify that the Grade tab is visible to the user
        3. Verify that the Submission tab is visible to the user
        4. Verify that the Edit submission button is not present in the Submission tab
      3. Login to the site on the Mobile App as Claire Student
        1. Navigate to Assignment
        2. Verify that the Grade tab is not visible to the user
        3. Verify that the details of a submission are shown to the user (it will show the due date and time though)
        4. Verify that the Add submission button is not present
      Show
      Setup Create a Course Create an Assignment in Course using the following settings: Allow submissions from is set to be in the past Due date is set to be in the future Submission types : Online text Feedback types : Feedback comments Require students to click the submit button : Yes Attempts reopened : Manually Create users Anne Student , Bob Student , Claire Student , David Student , Felicity Student and George Student enrol them as a student on Course Create user Emma Teacher and enrol them as a teacher on Course Enable Mobile Web services in the site Adding data to the assignment Login as Anne Student Navigate to Assignment Press the Add submission button Enter some text in the Online text box. Press Save changes Add a comment to the Submission comments Press Submit assignment Login as Bob Student Navigate to Assignment Press the Add submission button Enter some text in the Online text box. Press Save changes Press Submit assignment Login as David Student Navigate to Assignment Press the Add submission button Enter some text in the Online text box. Press Save changes Press Submit assignment Login as Felicity Student Navigate to Assignment Press the Add submission button Enter some text in the Online text box. Press Save changes Login as George Student Navigate to Assignment Login as Emma Teacher Navigate to Assignment Press View all submissions Press the Grade button for Anne Student Press Save changes For David Student in the Edit action menu select Allow another attempt Tests for removing assign:submit capability Preparation Login as Admin Navigate to Assignment Open the action menu and select Permissions and confirm the action In the Filter enter assign:submit Click the plus symbol in the prohibit column for the Submit assignment row Press the Student button in the Prohibit role dialogue box Confirm that Student now appears in the Prohibited column of the Submit assignment role Students can view their submissions Login as Anne Student Navigate to Assignment Verify that the Grading summary is not visible to the user Verify that the Submission status is visible to the user Verify that the Edit submission button is not present Login as Bob Student Navigate to Assignment Verify that the Grading summary is visible to the user Verify that the Submission status is visible to the user Verify that the Add submission button is not present Login as Claire Student Navigate to Assignment Verify that the Grading summary is not visible to the user Verify that the Submission status is not visible to the user Login as David Student Navigate to Assignment Verify that the Grading summary is visible to the user Verify that the Submission status is visible to the user Verify that the Add submission button is not present Verify that the Add a new attempt based on previous submission button is not present Verify that the Add a new attempt button is not present Login as Felicity Student Navigate to Assignment Verify that the Grading summary is visible to the user Verify that the Submission status is visible to the user Verify that the Add submission button is not present Verify that the Edit submission button is not present Verify that the Remove submission button is not present Verify that the Submit assignment button is not present Login as George Student Navigate to Assignment Verify that the Grading summary is not visible to the user Verify that the Submission status is not visible to the user Teacher can see users who have submitted Login as Emma Teacher Navigate to Assignment Press View all submissions Verify that the following students are in the list: Anne Student Bob Student David Student Felicity Student Verify that the following students do not appear in the list: Claire Student George Student Preparation for the following tests Login as Admin Navigate to Assignment Open the action menu and select Permissions and confirm the action In the Filter enter assign:submit Press the Delete icon next to student Confirm that Student now appears in the Roles with permission column of the Submit assignment role Tests for context freezing Preparation Login as Admin Navigate to " Site administration | Development | Experimental | Experimental settings " and enable " Context freezing (contextlocking) " Navigate to " Site administration | Mobile app |Mobile settings " and enable " Enable web services for mobile devices " Navigate to Assignment Open the action menu and select Freeze this context and confirm the action Users can see submissions when frozen Login as Anne Student Navigate to Assignment Verify that the Grading summary is not visible to the user Verify that the Submission status is visible to the user Verify that the Submission comments can be viewed, but that the new comment area is not present Verify that the Edit submission button is not present Login as Bob Student Navigate to Assignment Verify that the Grading summary is visible to the user Verify that the Submission status is visible to the user Verify that the Add submission button is not present Login as Claire Student Navigate to Assignment Verify that the Grading summary is not visible to the user Verify that the Submission status is not visible to the user Login as David Student Navigate to Assignment Verify that the Grading summary is visible to the user Verify that the Submission status is visible to the user Verify that the Add submission button is not present Verify that the Add a new attempt based on previous submission button is not present Verify that the Add a new attempt button is not present Login as Felicity Student Navigate to Assignment Verify that the Grading summary is visible to the user Verify that the Submission status is visible to the user Verify that the Add submission button is not present Verify that the Edit submission button is not present Verify that the Remove submission button is not present Verify that the Submit assignment button is not present Login as George Student Navigate to Assignment Verify that the Grading summary is not visible to the user Verify that the Submission status is not visible to the user Teacher can see users who have submitted Login as Emma Teacher Navigate to Assignment Press View all submissions Verify that you can see the Grade and Final grade columns in the table Verify that you can see a submission for Anne Student and that the submission made can be viewed in the Online text column Verify that you can see a submission for Bob Student and that the submission made can be viewed in the Online text column the comments you made are visible in the Feedback comments column the grade you gave them displays in the Grade and Final grade columns Verify that you can see a submission for David Student and that the submission made can be viewed in the Online text column Verify that you can see a submission for Felicity Student and that the submission made can be viewed in the Online text column Note: Claire Student and George Student should either both appear or both not appear in the list depending on the status of MDL-64410. This test should fail if only one of them appears in the list. Users can see submissions when frozen in the Moodle App Login to the site on the Mobile App as Anne Student Navigate to Assignment Verify that the no tabs are visible to the user Verify that details of the submission are visible to the user Verify that the Edit submission button is not present Login to the site on the Mobile App as Bob Student Navigate to Assignment Verify that the Grade tab is visible to the user Verify that the Submission tab is visible to the user Verify that the Edit submission button is not present in the Submission tab Login to the site on the Mobile App as Claire Student Navigate to Assignment Verify that the Grade tab is not visible to the user Verify that the details of a submission are shown to the user (it will show the due date and time though) Verify that the Add submission button is not present
    • Affected Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      If a student visits an assignment that they have made a submission to after it has been frozen they cannot see any information about the submission they made.

      This seems to be because they are only shown information about submissions if they have the mod/assign:submit capability which is a write capability (and so automatically return false).

      Steps to reproduce

      1. Create an assignment (Assignment 1) that is not Frozen
      2. As a Student submit to Assignment 1
      3. As Admin visit Assignment 1
      4. From the action menu select Freeze this content and accept the freeze
      5. As Student visit Assignment 1

      Outcome

      I see the title and description of the assignment, but no details of my submission.

      Expectation

      I expect to see details of the submission and comments made, but not be able to modify it the submission, or add new comments.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                nmagill Neill Magill
                Reporter:
                nmagill Neill Magill
                Integrator:
                Sara Arjona (@sarjona)
                Participants:
                Component watchers:
                Damyon Wiese, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                2 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 6 minutes
                  6m