[MDL-64345] Error upgrading (oauth2_issuer) - ORA-00932 inconsistent datatypes - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.5.3
Fix Version/s: 3.5.4, 3.6.2
Component/s: Database SQL/XMLDB
Labels:
- ci
- oracle
- triaged

Database:

Oracle
Testing Instructions:
Hide

Test on Oracle and one other database (e.g. MySQL or PostgreSQL)

Check out the Moodle 3.5.2 tag

git checkout v3.5.2

Install your Moodle instance.

Log in as an admin and go to Site administration / Services / OAuth2 services

Create a new Facebook service. (It doesn't matter what the Client ID and Secret are, you can put anything).

Check out the latest version with this patch applied.

master: git checkout master

36: git checkout MOODLE_36_STABLE

35: git checkout MOODLE_35_STABLE

Upgrade your Moodle site

Confirm that the upgrade succeeds.

Go back to the OAuth2 services page.

Confirm that the Facebook logo is shown beside the OAuth2 issuer name.
Show
Test on Oracle and one other database (e.g. MySQL or PostgreSQL) Check out the Moodle 3.5.2 tag git checkout v3.5.2 Install your Moodle instance. Log in as an admin and go to Site administration / Services / OAuth2 services Create a new Facebook service. (It doesn't matter what the Client ID and Secret are, you can put anything). Check out the latest version with this patch applied. master: git checkout master 36: git checkout MOODLE_36_STABLE 35: git checkout MOODLE_35_STABLE Upgrade your Moodle site Confirm that the upgrade succeeds. Go back to the OAuth2 services page. Confirm that the Facebook logo is shown beside the OAuth2 issuer name.
Affected Branches:
MOODLE_35_STABLE
Fixed Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE
Pull from Repository:
https://github.com/s-cenni/MDL-64345
Pull 3.5 Branch:
~~MDL-64345~~-35
Pull 3.5 Diff URL:
https://github.com/s-cenni/MDL-64345/compare/MOODLE_35_STABLE...MDL-64345-35
Pull Master Branch:
~~MDL-64345~~-master
Pull Master Diff URL:
https://github.com/s-cenni/MDL-64345/compare/master...MDL-64345-master

Description

I tried to upgrade Moodle to version 3.5.3 (using ORACLE).

I got this error:

ORA-00932: inconsistent datatypes: expected - got CLOB

The problem is caused by this query, because image field is a CLOB:

$updatesql = "UPDATE {oauth2_issuer}

 SET image = :newimage

 WHERE image = :oldimage";

in file: lib/db/upgrade.php line: 2322

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

image-2019-01-10-16-47-41-991.png
198 kB
10/Jan/19 4:47 PM
image-2019-01-10-16-47-55-372.png
284 kB
10/Jan/19 4:48 PM

Activity

People

Assignee:: Sara Cenni

Reporter:: Sara Cenni

Peer reviewer:: Jun Pataleta

Integrator:: Jake Dallimore

Tester:: Janelle Barcega

Participants:: CiBoT, Dan Marsden, Eloy Lafuente (stronk7), Jake Dallimore, Janelle Barcega, Jun Pataleta, Sara Cenni

Component watchers:: Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 1 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 07/Dec/18 12:23 AM

Updated:: 15/Jan/19 6:23 PM

Resolved:: 11/Jan/19 1:43 AM

Fix Release Date:: 14/Jan/19

Time Tracking

Estimated:

Remaining:

Logged: