Loading...

XML

Word

Printable

Affected Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_36_STABLE
Pull from Repository:
git://github.com/lameze/moodle.git
Pull Main Branch:
~~MDL-64425~~-master
Pull Main Diff URL:
https://github.com/lameze/moodle/compare/33a388eff7...MDL-64425-master
Testing Instructions:
Hide

Open the browser console.

Log in as admin

Add the Timeline block to your dashboard.

Make sure the following error is not displayed in the console.

M.util.get_string: invalid value type for $a->active
Show
Open the browser console. Log in as admin Add the Timeline block to your dashboard. Make sure the following error is not displayed in the console. M.util.get_string: invalid value type for $a->active

Just noticed this JS error in my console:

yui_combo.php:5828 M.util.get_string: invalid value type for $a->active

INSTANCE.log @ yui_combo.php?rollup/3.17.2/yui-moodlesimple.js:5828

Debugging a bit it seems it is calling get_string function passing the third argument active as boolean.

is a regression caused by

MDL-63817 Add page limit persistence to timeline block

Participants:: CiBoT, Gareth J Barnard, Janelle Barcega, Peter Dias, Sara Arjona (@sarjona), Simey Lameze

Estimated:

Remaining:

Logged:

22m