Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64432

No string 'starred' for the my overview block in overridden Boostrapbase template

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6.1, 3.7
    • Fix Version/s: 3.6.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Login as Admin
      2. Select the Clean theme.
      3. Create a course (any format) and enrol yourself on it, manual as a student.
      4. Navigate to the 'Dashboard' page.
      5. Ensure that the 'Course overview' block is there and shows the course that you have just created and enrolled on.
      6. Click the three menu dots on the right of the course '...' and hover over the 'star' icon on the option 'Star this course'.
      7. Confirm that the words in the tool tip state 'Starred'.
      Show
      Login as Admin Select the Clean theme. Create a course (any format) and enrol yourself on it, manual as a student. Navigate to the 'Dashboard' page. Ensure that the 'Course overview' block is there and shows the course that you have just created and enrolled on. Click the three menu dots on the right of the course '...' and hover over the 'star' icon on the option 'Star this course'. Confirm that the words in the tool tip state 'Starred'.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.6 Branch:
      MDL-64432_m36
    • Pull Master Branch:
      MDL-64432_master

      Description

      With developer level debugging on, the PHP log file reports:

      Debugging: Invalid get_string() identifier: 'starred' or component 'block_myoverview'. Perhaps you are missing $string['starred'] = ''; in F:\moodledev\moodle36/blocks/myoverview/lang/en/block_myoverview.php? in 
      * line 349 of \lib\classes\string_manager_standard.php: call to debugging()
      * line 117 of \lib\external\externallib.php: call to core_string_manager_standard->get_string()
      * line 244 of \lib\externallib.php: call to core_external::get_string()
      * line 59 of \lib\ajax\service.php: call to external_api::call_external_function()
      * line 31 of \lib\ajax\service-nologin.php: call to require_once() 

      This happens because in the file /theme/bootstrapbase/templates/block_myoverview/course-action-menu.mustache there is the line:

      {{#pix}} i/star, core, {{#str}} starred, block_myoverview {{/str}} {{/pix}} 

      however the file /blocks/myoverview/templates/course-action-menu.mustache has:

      {{#pix}} i/star, core, {{#str}} favourites, block_myoverview {{/str}} {{/pix}} 

      and in /blocks/myoverview/lang/en/block_myoverview.php there is no string 'starred'.

      This is clearly a bug and 'starred' needs to be changed to 'favourites'.

      I've added some testing instructions which could be changed if you know where exactly the string should appear in the markup or tooltip etc.

       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                gb2048 Gareth J Barnard
                Reporter:
                gb2048 Gareth J Barnard
                Peer reviewer:
                Bas Brands
                Integrator:
                Sara Arjona (@sarjona)
                Tester:
                Anna Carissa Sadia
                Participants:
                Component watchers:
                Bas Brands, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Mar/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 15 minutes
                  15m