Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64464

Drag-drop question types do not allow use of mixed languages

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      First decide if you are happy to test this by inspecting the HTML in the browser, or if you acutally want to find a screen-reader that supports more than one language.

      Then, for each of the three question types:

      • Drag-drop into text
      • Drag-drop onto image (with draggable type = text).
      • Drag-drop markers

      Create a question where the question text is in English (or whatever the default languages of your Moodle site is) and the draggable choices are in another language. (For a more specific example, for drag-drop into text, see the description of this issue.)

      Then, preview the question with some screen-reader, and verify that the the drag items are read with the correct accent (or, that at least the <span lang=".."> tags are present in the HTML.

      Note: there is some unit test coverage of this already. The manual testing is just a backup.

      Show
      First decide if you are happy to test this by inspecting the HTML in the browser, or if you acutally want to find a screen-reader that supports more than one language. Then, for each of the three question types: Drag-drop into text Drag-drop onto image (with draggable type = text). Drag-drop markers Create a question where the question text is in English (or whatever the default languages of your Moodle site is) and the draggable choices are in another language. (For a more specific example, for drag-drop into text, see the description of this issue.) Then, preview the question with some screen-reader, and verify that the the drag items are read with the correct accent (or, that at least the <span lang=".."> tags are present in the HTML. Note: there is some unit test coverage of this already. The manual testing is just a backup.
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull 3.5 Diff URL:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      Suppose you have a course in English, about the French language.

      And suppose that you have disabled students, so that it is important that the text in your questions is read correctly by screen-readers.

      Then, you may want a question:

      <p>Put the right word in this phrase:</p>
      		 
       
      		 
      <p lang="fr">[[1]] chat s'est assis sur [[1]] tapis</p>
      		 
       
      		 
      1: [ le ]
      		 
      2: [ la ]
      		 
      3: [ l' ]

      This does not work, because the drag items are outside the <p> tag, so are not read by the screen reader with the proper accent.

      To fix this, we need to add <span lang=".."> to the set of allowed tags in drag items.

        Attachments

          Activity

            People

            Assignee:
            timhunt Tim Hunt
            Reporter:
            timhunt Tim Hunt
            Peer reviewer:
            Mahmoud Kassaei
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Simey Lameze
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Mar/19