Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64482

Review not needed anymore PHP 5.x & 7.0 checks uses in core

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Duplicate
    • Icon: Minor Minor
    • None
    • 3.7
    • General
    • None
    • MOODLE_37_STABLE

      Since Moodle 3.7 (see MDL-63276), Moodle requires PHP 7.1.x.

      There are a number of checks / comments / conditional coding in core looking for old PHP 5.x and 7.0.x versions.

      This issue is about to visit all those cases, review them and, when unnecessary, take rid of those checks / comments / conditional coding, keeping core working with the supported PHP versions.

      This is a quick and dirty grep about current cases needing review (note a bunch of them - composer, environment, install lang files, 3rd part libraries... - can be considered false positives...):

      ag --php 'php.*(5\.[456]|7\.0)'

      Results: https://pastebin.com/TxWa5b7a (worth updating this when the work here begins).

      And that's all, ciao

            Unassigned Unassigned
            stronk7 Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.