Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64494

Contrast of colours for success, info, error and warnings text is not accessible

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Download the Moodle Component library plugin from https://github.com/bmbrands/moodle-tool_componentlibrary

      1. Login as admin
      2. Install the component library plugin
      3. Navigate to System Administration > Themes
      4. Check the option "Allow theme changes in the URL"
      5. Navigate to System Administration > Development > UI Component library
      6. In the Component Library go to Moodle 3.9 > Accessibility > Contrast
      7. Check the contrast labels on the "Theme Buttons" Section
      8. Verify all checks are green (value above 4.50:1)
      9. Click the theme selector in the top navbar
      10. Select "Classic"
      11. Verify all again checks are green (value above 4.50:1)
      Show
      Download the Moodle Component library plugin from https://github.com/bmbrands/moodle-tool_componentlibrary Login as admin Install the component library plugin Navigate to System Administration > Themes Check the option "Allow theme changes in the URL" Navigate to System Administration > Development > UI Component library In the Component Library go to Moodle 3.9 > Accessibility > Contrast Check the contrast labels on the "Theme Buttons" Section Verify all checks are green (value above 4.50:1) Click the theme selector in the top navbar Select "Classic" Verify all again checks are green (value above 4.50:1)
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-64494-master
    • Story Points:
      8

      Description

      The success, error, warning and info text classes default colours from Bootstrap are not accessible. WAVE accessibility checker reports:

      "Very low contrast between foreground and background colors."

      This affects all pages using the Bootstrap success, error, warning and info classes including the performance info in the footer of each page and all "notifications" using a Bootstrap alert.

        Attachments

        1. buttons_changes.png
          97 kB
          Eloy Lafuente (stronk7)
        2. chrome_notifications_colours.png
          51 kB
          Jake Dallimore
        3. hex values needed.png
          244 kB
          Barbara Ramiro
        4. image-2020-02-28-14-10-12-179.png
          24 kB
          Hina Khan
        5. image-2020-04-01-10-21-04-086.png
          84 kB
          Janelle Barcega
        6. MDL-64494_35.patch
          54 kB
          Eloy Lafuente (stronk7)
        7. MDL-64494_36.patch
          54 kB
          Eloy Lafuente (stronk7)
        8. MDL-64494_master.patch
          54 kB
          Eloy Lafuente (stronk7)
        9. MDL-64494.jpg
          56 kB
          Anna Carissa Sadia
        10. MDL-64494 (2).jpg
          65 kB
          Anna Carissa Sadia
        11. notifications_changes.png
          86 kB
          Eloy Lafuente (stronk7)
        12. screenshot-1.png
          48 kB
          Damyon Wiese
        13. screenshot-2.png
          44 kB
          Damyon Wiese
        14. Screenshot 2020-02-20 at 12.05.35.png
          152 kB
          Bas Brands
        15. Screenshot from 2019-04-23 06-18-59.png
          52 kB
          David Monllaó
        16. sitehome-links.png
          21 kB
          Jun Pataleta
        17. Test failed_35.PNG
          36 kB
          Gladys Basiana

          Issue Links

            Activity

              People

              Assignee:
              basbrands Bas Brands
              Reporter:
              damyon Damyon Wiese
              Peer reviewer:
              Jun Pataleta Jun Pataleta
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Janelle Barcega Janelle Barcega
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              2 Vote for this issue
              Watchers:
              20 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 days, 1 hour, 30 minutes
                  3d 1h 30m