Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64495

Add new setting page for messaging related settings

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      As an admin

      1. Check there's a new 'Messaging' category in main Site administration Page.
      2. Check  'Messaging' category has, at least, 2 setting pages.
        • 'Message settings' page must have 'Enable messaging system', 'Allow site-wide messaging', 'Use enter to send enabled by default', 'Delete read notifications', 'Delete all notifications' and 'Notification email override' settings.
        • 'Notification settings' page must have options to enable/disable 'Notification plugins' and for each notification plugin is enabled, must have 'Default notification preferences' options for different modules and activities.
      3. Access to 'Notification settings'.
      4. Click the checkbox next to a disabled notification plugin (e.g. Jabber). 
      5. Before saving, check the 'Default notification preferences section (the lower portion of the page), and verify you don't see a column for the plugin you selected in step 4 (I.e. Jabber).
      6. Click the 'Save changes' button.
      7. Check there is a column for the enabled plugin (i.e. Jabber) in the 'Default notification preferences' section.
      8. Go to Site administration.
      9. Check under the 'Notification settings' there's a link to the plugin's settings page for each notification plugin enabled in 'Notification settings' page with a 'Settings' link (i.e. Jabber)
      10. Check 'Enable messaging system', 'Allow site-wide messaging', 'Use enter to send enabled by default', 'Delete read notifications', 'Delete all notifications' and 'Notification email override' settings are not any longer in 'Advanced features' settings page.
      11. Check there's no 'Message outputs' category in Plugins admin page 

      As an admin, check all messaging settings work as expected:

      1. Go to Site administration -> Messaging -> Messaging settings
      2. Enable 'Enable messaging system' setting and Save changes. Check 'Toggle messaging drawer' is visible on the left side of the user menu.
      3. Disable 'Enable messaging system' setting and Save changes. Check 'Toggle messaging drawer' is not visible on the left side of the user menu.
      4. Enable 'Allow site-wide messaging' setting and Save changes. As a non admin user click on 'Toggle messaging drawer' icon and search for a user that is not enrolled in any of your courses. Check you can find them.
      5. Disable 'Allow site-wide messaging' setting and Save changes. As a non admin user click on 'Toggle messaging drawer' icon and search for a user that is not enrolled in any of your courses. Check you can't find them.
      6. Enable 'Use enter to send enabled by default' and Save changes. Click on 'Toggle messaging drawer' icon and search for a user. Click on one of the results and write a message to it. Check message is sent when you press Enter.
      7. Disable 'Use enter to send enabled by default' and Save changes. Click on 'Toggle messaging drawer' icon and search for a user. Click on one of the results and write a message to it. Check message is not sent when you press Enter, and you need to click in 'Send message' icon.
      8. Go to Site administration -> Messaging -> Notification settings, disable 'Web' and check 'Toggle notifications menu' is not visible on the left side of the user menu.
      9. Go to Site administration -> Messaging -> Notification settings, enable 'Web' and check 'Toggle notifications menu' not visible on the left side of the user menu.
      Show
      As an admin Check there's a new 'Messaging' category in main Site administration Page. Check  'Messaging' category has, at least, 2 setting pages. 'Message settings' page must have 'Enable messaging system', 'Allow site-wide messaging', 'Use enter to send enabled by default', 'Delete read notifications', 'Delete all notifications' and 'Notification email override' settings. 'Notification settings' page must have options to enable/disable 'Notification plugins' and for each notification plugin is enabled, must have 'Default notification preferences' options for different modules and activities. Access to 'Notification settings'. Click the checkbox next to a disabled notification plugin (e.g. Jabber).  Before saving, check the 'Default notification preferences section (the lower portion of the page), and verify you don't see a column for the plugin you selected in step 4 (I.e. Jabber). Click the 'Save changes' button. Check there is a column for the enabled plugin (i.e. Jabber) in the 'Default notification preferences' section. Go to Site administration. Check under the 'Notification settings' there's a link to the plugin's settings page for each notification plugin enabled in 'Notification settings' page with a 'Settings' link (i.e. Jabber) Check 'Enable messaging system', 'Allow site-wide messaging', 'Use enter to send enabled by default', 'Delete read notifications', 'Delete all notifications' and 'Notification email override' settings are not any longer in 'Advanced features' settings page. Check there's no 'Message outputs' category in Plugins admin page  As an admin, check all messaging settings work as expected: Go to Site administration -> Messaging -> Messaging settings Enable 'Enable messaging system' setting and Save changes. Check 'Toggle messaging drawer' is visible on the left side of the user menu. Disable 'Enable messaging system' setting and Save changes. Check 'Toggle messaging drawer' is not visible on the left side of the user menu. Enable 'Allow site-wide messaging' setting and Save changes. As a non admin user click on 'Toggle messaging drawer' icon and search for a user that is not enrolled in any of your courses. Check you can find them. Disable 'Allow site-wide messaging' setting and Save changes. As a non admin user click on 'Toggle messaging drawer' icon and search for a user that is not enrolled in any of your courses. Check you can't find them. Enable 'Use enter to send enabled by default' and Save changes. Click on 'Toggle messaging drawer' icon and search for a user. Click on one of the results and write a message to it. Check message is sent when you press Enter. Disable 'Use enter to send enabled by default' and Save changes. Click on 'Toggle messaging drawer' icon and search for a user. Click on one of the results and write a message to it. Check message is not sent when you press Enter, and you need to click in 'Send message' icon. Go to Site administration -> Messaging -> Notification settings, disable 'Web' and check 'Toggle notifications menu' is not visible on the left side of the user menu. Go to Site administration -> Messaging -> Notification settings, enable 'Web' and check 'Toggle notifications menu' not visible on the left side of the user menu.
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-64495-master

      Description

      Currently messaging related settings sit under 'Site administration' > 'Advanced features'. This should not be defined as an 'Advanced feature' and should become common use in any Moodle site. We should define a unique location for these settings in the main Site Administration category called 'Messaging'.

      We should add all Messaging related settings to a new page called 'Messaging settings'  in the 'Messaging' category.  

      The content from the 'Manage message outputs page' page should go in a new 'Notification settings' page with all the content from 'Default message outputs'.

      Note that the 'eye' icon for enabling the message outputs (Manage message outputs page) should be a checkbox to make clear it enables/disables rather than just show or hides notification settings for the user.

      Links to messaging plugins' settings page should be moved from Plugin admin page to the new 'Messaging' category in the main site administration page.

        Attachments

        1. 1.png
          1.png
          183 kB
        2. 2.png
          2.png
          169 kB
        3. 3.png
          3.png
          159 kB
        4. 4.png
          4.png
          117 kB
        5. After - Enable notificaiton plugins.png
          After - Enable notificaiton plugins.png
          163 kB
        6. After - Manage message outputs.png
          After - Manage message outputs.png
          106 kB
        7. After - Message outputs.png
          After - Message outputs.png
          59 kB
        8. Before - Enable notificaiton plugins.png
          Before - Enable notificaiton plugins.png
          53 kB
        9. Before - Mange message outputs.png
          Before - Mange message outputs.png
          39 kB
        10. Before - Message outputs.png
          Before - Message outputs.png
          76 kB
        11. Default message outputs.png
          Default message outputs.png
          382 kB
        12. Notification preferences.png
          Notification preferences.png
          369 kB
        13. notifications_plugins.png
          notifications_plugins.png
          39 kB
        14. notification settings.png
          notification settings.png
          180 kB

          Issue Links

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                12 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 43 minutes
                  1h 43m