Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64505

Introduce the classic theme to core

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.7
    • Component/s: Themes
    • Testing Instructions:
      Hide

      PHPUnit and Behat runs pass, apart from a behat test that fails due to an unrelated issue that was integrated last week.

      Latest Behat test: https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/668/

      A visual check of Moodle using the Classic theme, to ensure it appears similar to the Boost theme, apart from the navigation structure, which should be similar in functionality to the Clean theme (eg expandable site administration, navigation block available, instead of Boost drawer and settings cogs).

      Testers

      • Please go to MDLQA-12873 and complete the sub-tasks on that QA test.
      Show
      PHPUnit and Behat runs pass, apart from a behat test that fails due to an unrelated issue that was integrated last week. Latest Behat test: https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/668/ A visual check of Moodle using the Classic theme, to ensure it appears similar to the Boost theme, apart from the navigation structure, which should be similar in functionality to the Clean theme (eg expandable site administration, navigation block available, instead of Boost drawer and settings cogs). Testers Please go to MDLQA-12873 and complete the sub-tasks on that QA test.
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull Master Branch:
      MDL-64505-master-final

      Description

      Implement the theme available at https://github.com/bmbrands/moodle-theme_classic into core.

      Within the classic repo:

      1. Remove LICENSE
      2. Remove README.txt
      3. Check version.php
      4. Add to lib/classes/plugin_manager.php list of core plugins

      There are a few remaining bits to complete, notably:

      1. Check if templates are still required once MDL-58428 lands
      2. Check for any behat changes/overrides required
      3. Add a more detailed 'choosereadme' language string in /theme/classic/lang/en/theme_classic.php
      4. Block docking has been added as a separate linked issue, which can land after the introduction of the theme if needed.

      Also:

      1. Prototype site ASAP

        Attachments

        1. adminsearch_display.png
          adminsearch_display.png
          63 kB
        2. block_display.png
          block_display.png
          168 kB
        3. calendar_displaye.png
          calendar_displaye.png
          133 kB
        4. ClassicThemeScreenshot.png
          ClassicThemeScreenshot.png
          214 kB
        5. classicthemesetting.png
          classicthemesetting.png
          56 kB
        6. courseoverviewblock.png
          courseoverviewblock.png
          223 kB
        7. navigation.png
          navigation.png
          54 kB
        8. page_header.png
          page_header.png
          84 kB
        9. RTLlanguage.png
          RTLlanguage.png
          157 kB
        10. RTLlanguage2.png
          RTLlanguage2.png
          93 kB
        11. Screenshot from 2019-03-19 14-56-49.png
          Screenshot from 2019-03-19 14-56-49.png
          13 kB
        12. Screenshot from 2019-03-19 15-11-14.png
          Screenshot from 2019-03-19 15-11-14.png
          14 kB
        13. tabs_display.png
          tabs_display.png
          73 kB
        14. usertour_display.png
          usertour_display.png
          263 kB
        15. usertour_display2.png
          usertour_display2.png
          174 kB

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                18 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 30 minutes
                  1d 30m