Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64505

Introduce the classic theme to core

XMLWordPrintable

    • MOODLE_37_STABLE
    • MOODLE_37_STABLE
    • MDL-64505-master-final
    • Hide

      PHPUnit and Behat runs pass, apart from a behat test that fails due to an unrelated issue that was integrated last week.

      Latest Behat test: https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/668/

      A visual check of Moodle using the Classic theme, to ensure it appears similar to the Boost theme, apart from the navigation structure, which should be similar in functionality to the Clean theme (eg expandable site administration, navigation block available, instead of Boost drawer and settings cogs).

      Testers

      • Please go to MDLQA-12873 and complete the sub-tasks on that QA test.
      Show
      PHPUnit and Behat runs pass, apart from a behat test that fails due to an unrelated issue that was integrated last week. Latest Behat test: https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/668/ A visual check of Moodle using the Classic theme, to ensure it appears similar to the Boost theme, apart from the navigation structure, which should be similar in functionality to the Clean theme (eg expandable site administration, navigation block available, instead of Boost drawer and settings cogs). Testers Please go to MDLQA-12873 and complete the sub-tasks on that QA test.

      Implement the theme available at https://github.com/bmbrands/moodle-theme_classic into core.

      Within the classic repo:

      1. Remove LICENSE
      2. Remove README.txt
      3. Check version.php
      4. Add to lib/classes/plugin_manager.php list of core plugins

      There are a few remaining bits to complete, notably:

      1. Check if templates are still required once MDL-58428 lands
      2. Check for any behat changes/overrides required
      3. Add a more detailed 'choosereadme' language string in /theme/classic/lang/en/theme_classic.php
      4. Block docking has been added as a separate linked issue, which can land after the introduction of the theme if needed.

      Also:

      1. Prototype site ASAP

        1. adminsearch_display.png
          63 kB
          Janelle Barcega
        2. block_display.png
          168 kB
          Janelle Barcega
        3. calendar_displaye.png
          133 kB
          Janelle Barcega
        4. ClassicThemeScreenshot.png
          214 kB
          Mary Cooch
        5. classicthemesetting.png
          56 kB
          Janelle Barcega
        6. courseoverviewblock.png
          223 kB
          Janelle Barcega
        7. navigation.png
          54 kB
          Janelle Barcega
        8. page_header.png
          84 kB
          Janelle Barcega
        9. RTLlanguage.png
          157 kB
          Janelle Barcega
        10. RTLlanguage2.png
          93 kB
          Janelle Barcega
        11. Screenshot from 2019-03-19 14-56-49.png
          13 kB
          Adrian Greeve
        12. Screenshot from 2019-03-19 15-11-14.png
          14 kB
          Adrian Greeve
        13. tabs_display.png
          73 kB
          Janelle Barcega
        14. usertour_display.png
          263 kB
          Janelle Barcega
        15. usertour_display2.png
          174 kB
          Janelle Barcega

            michaelh Michael Hawkins
            dobedobedoh Andrew Lyons
            Mathew May Mathew May
            Adrian Greeve Adrian Greeve
            Janelle Barcega Janelle Barcega
            Votes:
            1 Vote for this issue
            Watchers:
            18 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 30 minutes
                1d 30m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.