Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64505

Introduce the classic theme to core

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 3.7
    • 3.7
    • Themes
    • MOODLE_37_STABLE
    • MOODLE_37_STABLE
    • MDL-64505-master-final
    • Hide

      PHPUnit and Behat runs pass, apart from a behat test that fails due to an unrelated issue that was integrated last week.

      Latest Behat test: https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/668/

      A visual check of Moodle using the Classic theme, to ensure it appears similar to the Boost theme, apart from the navigation structure, which should be similar in functionality to the Clean theme (eg expandable site administration, navigation block available, instead of Boost drawer and settings cogs).

      Testers

      • Please go to MDLQA-12873 and complete the sub-tasks on that QA test.
      Show
      PHPUnit and Behat runs pass, apart from a behat test that fails due to an unrelated issue that was integrated last week. Latest Behat test: https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/668/ A visual check of Moodle using the Classic theme, to ensure it appears similar to the Boost theme, apart from the navigation structure, which should be similar in functionality to the Clean theme (eg expandable site administration, navigation block available, instead of Boost drawer and settings cogs). Testers Please go to MDLQA-12873 and complete the sub-tasks on that QA test.

    Description

      Implement the theme available at https://github.com/bmbrands/moodle-theme_classic into core.

      Within the classic repo:

      1. Remove LICENSE
      2. Remove README.txt
      3. Check version.php
      4. Add to lib/classes/plugin_manager.php list of core plugins

      There are a few remaining bits to complete, notably:

      1. Check if templates are still required once MDL-58428 lands
      2. Check for any behat changes/overrides required
      3. Add a more detailed 'choosereadme' language string in /theme/classic/lang/en/theme_classic.php
      4. Block docking has been added as a separate linked issue, which can land after the introduction of the theme if needed.

      Also:

      1. Prototype site ASAP

      Attachments

        1. adminsearch_display.png
          63 kB
          Janelle Barcega
        2. block_display.png
          168 kB
          Janelle Barcega
        3. calendar_displaye.png
          133 kB
          Janelle Barcega
        4. ClassicThemeScreenshot.png
          214 kB
          Mary Cooch
        5. classicthemesetting.png
          56 kB
          Janelle Barcega
        6. courseoverviewblock.png
          223 kB
          Janelle Barcega
        7. navigation.png
          54 kB
          Janelle Barcega
        8. page_header.png
          84 kB
          Janelle Barcega
        9. RTLlanguage.png
          157 kB
          Janelle Barcega
        10. RTLlanguage2.png
          93 kB
          Janelle Barcega
        11. Screenshot from 2019-03-19 14-56-49.png
          13 kB
          Adrian Greeve
        12. Screenshot from 2019-03-19 15-11-14.png
          14 kB
          Adrian Greeve
        13. tabs_display.png
          73 kB
          Janelle Barcega
        14. usertour_display.png
          263 kB
          Janelle Barcega
        15. usertour_display2.png
          174 kB
          Janelle Barcega

        Issue Links

          blocks

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-64506 Remove clean theme

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has a non-specific relationship to

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-65105 Determine setup of dark navbar for Classic theme

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-65106 Determine navigation item icon use

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-64567 Add block docking functionality to the Classic theme

          • Minor - Minor loss of function where workaround is possible
          • Open

          Release Test - A set of tests for a single release MDLQA-12873 Moodle Classic theme testing

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Passed
          has to be done before

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-64924 Move message Boost theme behat tests to core_message behat tests

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDLSITE-5700 Apply for the new classic suite with behat @ CI servers

          • Low - Cosmetic problems, nice-to-have features
          • Closed
          is blocked by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-58428 Move all templates from boost to core and (where relevant) core to bootstrapbase

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          Testing discovered

          Improvement - An enhancement to an existing Moodle feature. MDL-65416 Improve Classic theme screenshot

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              michaelh Michael Hawkins
              dobedobedoh Andrew Lyons
              Mathew May Mathew May
              Adrian Greeve Adrian Greeve
              Janelle Barcega Janelle Barcega
              Huong Nguyen, Bas Brands, Mathew May
              Votes:
              1 Vote for this issue
              Watchers:
              18 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                20/May/19

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 30 minutes
                  1d 30m