Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64524

Assignment's frequently used comments popup interface not scrollable

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Note: Test in all themes (Boost, Classic (master only), Clean)

      Setup
      1. Purge all caches
      2. Ensure that Ghostscript is installed. (If you open your terminal and enter "which gs", you should see an output showing the path to Ghostscript)
      3. Visit Site administration ▶︎ Server ▶︎ System paths
      4. Ensure 'Path to Ghostscript' points to your Ghostscript executable
      5. Visit Site administration ▶︎ Plugins ▶︎ Activity modules ▶︎ Assignment ▶︎ Feedback plugins ▶︎ Annotate PDF
      6. Click on 'Test Ghostscript path' and confirm it is working
      7. Create an assignment with "Online text" enabled for submissions,  "Annotate PDF" enabled for feedback, and the "Grading method" set to "Marking guide".
      8. Click to view the assignment
      9. For the assignment settings click on "Define marking guide"
      10. Create a new "Marking guide" with several "Frequently used comments" with relatively long texts (Tip: You can use http://www.lipsum.com/)
      11. Grade a student in the assignment.

      Part 1 - Verify the quicklist comments in the pdf editor

      1. Choose the "Comments" tool in the pdf editor. 
      2. Click and drag a comment and write a relatively long comment (or use Lorem Ipsum). 
      3. Hover over the comment with the mouse and click the button to show the menu for the comment.
      4. Add the comment to the "quicklist" several times.
      5. Verify you can see all the comments in the quicklist and once the list got too long you were allowed to scroll.

      Part 2 - Verify the frequently used comments in the marking guide

      1. On the marking guide click the "Insert frequently used comments" button.
      2. Verify you can scroll up or down in the comments dialogue and can choose any of the comments.
      Show
      Note: Test in all themes (Boost, Classic (master only), Clean) Setup Purge all caches Ensure that Ghostscript is installed. (If you open your terminal and enter " which gs ", you should see an output showing the path to Ghostscript) Visit Site administration ▶︎ Server ▶︎ System paths Ensure 'Path to Ghostscript' points to your Ghostscript executable Visit Site administration ▶︎ Plugins ▶︎ Activity modules ▶︎ Assignment ▶︎ Feedback plugins ▶︎ Annotate PDF Click on 'Test Ghostscript path' and confirm it is working Create an assignment with "Online text" enabled for submissions,  "Annotate PDF" enabled for feedback, and the "Grading method" set to "Marking guide". Click to view the assignment For the assignment settings click on "Define marking guide" Create a new "Marking guide" with several "Frequently used comments" with relatively long texts (Tip: You can use http://www.lipsum.com/ ) Grade a student in the assignment. Part 1 - Verify the quicklist comments in the pdf editor Choose the "Comments" tool in the pdf editor.  Click and drag a comment and write a relatively long comment (or use Lorem Ipsum).  Hover over the comment with the mouse and click the button to show the menu for the comment. Add the comment to the "quicklist" several times. Verify you can see all the comments in the quicklist and once the list got too long you were allowed to scroll. Part 2 - Verify the frequently used comments in the marking guide On the marking guide click the "Insert frequently used comments" button. Verify you can scroll up or down in the comments dialogue and can choose any of the comments.
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull 3.6 Branch:
    • Pull Master Branch:
      MDL-64524-master

      Description

      When the teacher define many Frequently used comments (FUCs in brief) the assignment grading interface popup does not scroll and the latest ones are not selectable.

      This problem arises mostly in desktop browser, as in mobile ones it seems that the page itself can be scrolled and the long popup can be shown.

      I solved this by adding these lines to mod/assign/feedback/editpdf/styles.css

      .gradingform_guide_comment_chooser {

      height:80vh;

      overflow-y:auto;

      }

      Which redefine the overflow for the FUCs chooser.

       

      FULL STEPS to REPRODUCE:

      In a course, click on "advanced grading" and setup a grading method to marking guide.

      Now add many "standard" comments (almost 10/15).

      In the same course create an assignment and do a submission to be graded; now go to grade interface for this assignment and try to insert a comment selecting a FUC, by clicking on "insert frequently used comment".

      The popup expand itself over the page bottom border and you cannot scroll neither the page and the popup and you cannot select the latest FUCs in the list.

      I double-checked against Moodle 3.1.15, but taking a look at the assign plugin, i believe that this problem is current also in the latest moodle.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 7 hours
                  7h