Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64528

Marking item completion not prevented when context is frozen

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      This needs to be tested in both the web interface and with the mobile app. Create a course with some students. Enable course completion and add a label. Enable the context freezing feature.

      1. Ensure that the student can mark the activity as complete, and then mark it as incomplete.
      2. Ensure that an unenrolled administrator can mark the activity as complete, and then mark it as incomplete.
      3. Repeat steps 1-2 in the mobile app.
      4. Freeze the course.
      5. Ensure that the student cannot mark the activity as complete.
      6. Ensure that the administrator cannot mark the activity as complete.
      7. Repeat steps 5-6 in the mobile app.
      Show
      This needs to be tested in both the web interface and with the mobile app. Create a course with some students. Enable course completion and add a label. Enable the context freezing feature. Ensure that the student can mark the activity as complete, and then mark it as incomplete. Ensure that an unenrolled administrator can mark the activity as complete, and then mark it as incomplete. Repeat steps 1-2 in the mobile app. Freeze the course. Ensure that the student cannot mark the activity as complete. Ensure that the administrator cannot mark the activity as complete. Repeat steps 5-6 in the mobile app.
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-64528-master

      Description

      Freezing a context (course, category) does not prevent the checkbox for an item from being checked or unchecked, if the item is set to allow manual marking.

      Reproduction:

      Create a course.

      Add content that can be manually marked complete.

      Freeze the course at the course or category context.

      Log in as a student or use 'Switch role to' student role.

      Check and/or uncheck the completion of the content.

       

      Expected behavior:

      Should not be able to alter the completion of items in a frozen context.

       

      Actual behavior:

      Completion can be altered.

       

        Attachments

        1. MDL-64528_Step5.mp4
          449 kB
        2. MDL-64528_Step6.mp4
          428 kB
        3. MDL-64528.jpg
          MDL-64528.jpg
          33 kB

          Issue Links

            Activity

              People

              Assignee:
              cfulton Charles Fulton
              Reporter:
              chadberg Chad Bergeron
              Peer reviewer:
              Sam Marshall
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              3 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Mar/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h