Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64540

Backport MDL-60008 - File won't render in the grader if both submission types are selected

XMLWordPrintable

    • MOODLE_35_STABLE, MOODLE_36_STABLE
    • MOODLE_35_STABLE, MOODLE_36_STABLE
    • Hide
      1. Make sure your site has a working ghost script (Site administration / Plugins / Assignment plugins / Feedback plugins / Annotate PDF / Test ghostscript path), but no document converters enabled.
      2. Create an assignment with "Online text" and "File submissions" enabled in the "Submission types" section. Make sure 2 files can be submitted.
      3. Login as a student and submit a PDF file as the assignment submission with no online text.
      4. Login as a teacher and grade the submission. The PDF should appear in the grading interface and should only contain the submitted PDF so the teacher can draw / annotate it.
      5. Enable the unoconv document converter (make sure it is working)
      6. Login as the student and edit the submission so that it now has online text as well as a PDF.
      7. Login as a teacher and grade the submission. The PDF should appear in the grading interface and should contain the online text and the submitted PDF so the teacher can draw / annotate it.
      8. Login as the student and edit the submission. Add an MP3 file to the submission.
      9. Login as a teacher and grade the submission. The PDF should appear in the grading interface so the teacher can draw / annotate it, but there should be a warning at the bottom of the PDF panel that indicates that there are some files can only be downloaded (The message will disappear after a while)
      10. Draw a line on the PDF and verify a message is displayed at the bottom of the PDF panel that says "Draft annotations saved". (The message will disappear after a while)

      Test all the following steps in "Boost" theme and "Clean" theme.

      1. Resize the window so it is narrow and verify the layout of the grading screen changes so that the panels are now displayed one after the other and the edit pdf panel is collapsible
      2. Open a menu (comment colour) from the edit PDF toolbar and verify the width of the menu does not rest of the browser window
      3. Open the search comments dialogue and verify the button to expand / collapse the review panel does not show through the background of the dialogue
      4. Resize the window so it is wider (at least 1000px) and verify the 3 buttons to change the layout of the panels are now visible at the bottom right corner.
      5. Verify the buttons to change the layout of the panels are not excessively tall (they should match the height of the "Save changes" button)

       

      Show
      Make sure your site has a working ghost script (Site administration / Plugins / Assignment plugins / Feedback plugins / Annotate PDF / Test ghostscript path), but no document converters enabled. Create an assignment with "Online text" and "File submissions" enabled in the "Submission types" section. Make sure 2 files can be submitted. Login as a student and submit a PDF file as the assignment submission with no online text. Login as a teacher and grade the submission. The PDF should appear in the grading interface and should only contain the submitted PDF so the teacher can draw / annotate it. Enable the unoconv document converter (make sure it is working) Login as the student and edit the submission so that it now has online text as well as a PDF. Login as a teacher and grade the submission. The PDF should appear in the grading interface and should contain the online text and the submitted PDF so the teacher can draw / annotate it. Login as the student and edit the submission. Add an MP3 file to the submission. Login as a teacher and grade the submission. The PDF should appear in the grading interface so the teacher can draw / annotate it, but there should be a warning at the bottom of the PDF panel that indicates that there are some files can only be downloaded (The message will disappear after a while) Draw a line on the PDF and verify a message is displayed at the bottom of the PDF panel that says "Draft annotations saved". (The message will disappear after a while) Test all the following steps in "Boost" theme and "Clean" theme. Resize the window so it is narrow and verify the layout of the grading screen changes so that the panels are now displayed one after the other and the edit pdf panel is collapsible Open a menu (comment colour) from the edit PDF toolbar and verify the width of the menu does not rest of the browser window Open the search comments dialogue and verify the button to expand / collapse the review panel does not show through the background of the dialogue Resize the window so it is wider (at least 1000px) and verify the 3 buttons to change the layout of the panels are now visible at the bottom right corner. Verify the buttons to change the layout of the panels are not excessively tall (they should match the height of the "Save changes" button)  

      MDL-60008 was a bug, but was integrated to master only. In https://tracker.moodle.org/browse/MDL-60008?focusedCommentId=647360&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-647360, it was agreed by damyon and jpataleta that there will be a backport request to backport MDL-60008 to stables, but this wasn't created during integration anymore as far as I see.

      As the creator of MDL-62467 which was closed as "will be solved by MDL-60008", I would be very keen to see MDL-60008 backported to stables. Thanks for your consideration.

        1. 1.png
          1.png
          166 kB
        2. 2.png
          2.png
          263 kB
        3. 3.png
          3.png
          305 kB
        4. screenshot-1.png
          screenshot-1.png
          86 kB

            damyon Damyon Wiese
            abias Alexander Bias
            Simey Lameze Simey Lameze
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Janelle Barcega Janelle Barcega
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours
                4h

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.