Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64552

Use hideif for Moodle forms inside admin/ top level directory

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. File types:
        1. Visit Site admin > Server > File types
        2. Edit one of the file types
        3. Change the Description type to Default
          1. Verify Custom description + Alternative language string are hidden
        4. Change the Description type to Custom description
          1. Verify Description is shown, Alternative language string is hidden
        5. Change the Description type to Alternative language string
          1. Verify Alternative language string is shown, Custom description is hidden
      2. Upload courses
        1. Visit Site admin > Courses > Upload courses
        2. Set Upload mode to 'create new only' or 'create all'
          1. Verify Update mode, allow deletes, allow renames, allow resets are hidden
        3. Set upload mode to 'create or update' or 'update only'
          1. Verify Update mode, allow deletes, allow renames, allow resets are shown
        4. Upload a suitable CSV and click 'Preview' (the file admin/tool/uploadcourse/tests/fixtures/courses.csv is suitable, if you don't already have a file)
        5. Set Upload mode to 'create new only' or 'create all'
          1. Verify Update mode, allow deletes, allow renames, allow resets, reset course after upload are hidden
          2. Verify Template to generate shortname is shown
        6. Set upload mode to 'create or update' or 'update only'
          1. Verify Update mode, allow deletes, allow renames, allow resets are shown
          2. Verify Reset course after upload is shown, but disabled
          3. Verify Template to generate shortname is hidden
        7. Set 'Allow resets' to yes
          1. Verify Reset course after upload is shown and enabled
      3. Upload users
        1. Visit Site admin > Users > Upload users
        2. Upload a suitable CSV file and click Preview (the file lib/tests/fixtures/upload_users.csv is suitable, if you don't already have a file)
        3. Set Upload type to 'add new' or 'add all'
          1. Verify Existing users details, Existing user password, Allow renames, Allow deletes, Allow suspending and activating are hidden
          2. Verify New user password is shown
        4. Set Upload type to 'add new and update' and Existing user details to 'no changes' or 'set missing'
          1. Verify Existing users details, Allow renames, Allow deletes, Allow suspending and activating are shown
          2. Verify New user password is shown
          3. Verify Existing user password is hidden
        5. Set Existing user details to 'Override with file' or 'Override with file and defaults' (leave Upload type unchanged)
          1. Verify Existing users details, Allow renames, Allow deletes, Allow suspending and activating are shown
          2. Verify New user password is shown
          3. Verify Existing user password is shown
        6. Set Upload type to 'update only' (leave Existing user details on 'Override')
          1. Verify Existing users details, Allow renames, Allow deletes, Allow suspending and activating are shown
          2. Verify New user password is hidden
          3. Verify Existing user password is shown
      4. User tours
        1. Visit Site admin > Appearance > User tours
        2. Click on 'View' icon beside a user tour
        3. Click on 'Edit' icon beside a user tour step
        4. Set 'Step target' to 'Block'
          1. Verify Block setting is shown
          2. Verify CSS selector setting is hidden
        5. Set 'Step target' to 'Selector'
          1. Verify Block setting is hidden
          2. Verify CSS selector setting is shown
        6. Set 'Step target' to 'middle of page'
          1. Verify Block setting is hidden
          2. Verify CSS selector setting is hidden
      Show
      File types: Visit Site admin > Server > File types Edit one of the file types Change the Description type to Default Verify Custom description + Alternative language string are hidden Change the Description type to Custom description Verify Description is shown, Alternative language string is hidden Change the Description type to Alternative language string Verify Alternative language string is shown, Custom description is hidden Upload courses Visit Site admin > Courses > Upload courses Set Upload mode to 'create new only' or 'create all' Verify Update mode, allow deletes, allow renames, allow resets are hidden Set upload mode to 'create or update' or 'update only' Verify Update mode, allow deletes, allow renames, allow resets are shown Upload a suitable CSV and click 'Preview' (the file admin/tool/uploadcourse/tests/fixtures/courses.csv is suitable, if you don't already have a file) Set Upload mode to 'create new only' or 'create all' Verify Update mode, allow deletes, allow renames, allow resets, reset course after upload are hidden Verify Template to generate shortname is shown Set upload mode to 'create or update' or 'update only' Verify Update mode, allow deletes, allow renames, allow resets are shown Verify Reset course after upload is shown, but disabled Verify Template to generate shortname is hidden Set 'Allow resets' to yes Verify Reset course after upload is shown and enabled Upload users Visit Site admin > Users > Upload users Upload a suitable CSV file and click Preview (the file lib/tests/fixtures/upload_users.csv is suitable, if you don't already have a file) Set Upload type to 'add new' or 'add all' Verify Existing users details, Existing user password, Allow renames, Allow deletes, Allow suspending and activating are hidden Verify New user password is shown Set Upload type to 'add new and update' and Existing user details to 'no changes' or 'set missing' Verify Existing users details, Allow renames, Allow deletes, Allow suspending and activating are shown Verify New user password is shown Verify Existing user password is hidden Set Existing user details to 'Override with file' or 'Override with file and defaults' (leave Upload type unchanged) Verify Existing users details, Allow renames, Allow deletes, Allow suspending and activating are shown Verify New user password is shown Verify Existing user password is shown Set Upload type to 'update only' (leave Existing user details on 'Override') Verify Existing users details, Allow renames, Allow deletes, Allow suspending and activating are shown Verify New user password is hidden Verify Existing user password is shown User tours Visit Site admin > Appearance > User tours Click on 'View' icon beside a user tour Click on 'Edit' icon beside a user tour step Set 'Step target' to 'Block' Verify Block setting is shown Verify CSS selector setting is hidden Set 'Step target' to 'Selector' Verify Block setting is hidden Verify CSS selector setting is shown Set 'Step target' to 'middle of page' Verify Block setting is hidden Verify CSS selector setting is hidden
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull Master Branch:
      MDL-64552_admin_hideif

      Description

      Review the forms in the admin/ directory for those which are candidates for switching disabledIf() to hideIf()

      See: admin - hideif.pdf for details of changes proposed

        Attachments

        1. MDL-64552 (2).jpg
          MDL-64552 (2).jpg
          50 kB
        2. MDL-64552.jpg
          MDL-64552.jpg
          57 kB
        3. admin - hideif.pdf
          623 kB

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                20/May/19

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m