Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64557

Use hideif for Moodle forms in the course/ directory

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Activity grouping settings
      1. Create a new 'forum' activity
      2. On the settings form, set 'Group mode' to 'No groups' (that is the default on your system, probably)
        • 'Grouping' setting should be hidden
      3. Set 'Group mode' to 'Separate' or 'Visible' groups
        • 'Grouping' setting should be shown
      Activity ratings
      1. Create a new 'forum' activity
      2. On the settings form, set the 'Aggregate type' to 'No ratings' (that is the default on your system, probably)
        • 'Scale' settings + 'Restrict ratings to items with dates in this range:' settings should be hidden
      3. Set 'Aggregate type' to anything other than 'No ratings'
        • 'Scale' settings + 'Restrict ratings to items with dates in this range:' settings should be shown
      Activity completion
      1. Create a new 'forum' activity
      2. On the settings form, set 'Completion tracking' to 'Do not indicate'
        • 'Require view', 'Require grade', all custom automatic rules (posts / discussions / replies), 'Expect completion on' - all should be hidden
      3. Set 'Completion tracking' to 'Students can manually mark the activity as completed'
        • 'Require view', 'Require grade', all custom automatic rules (posts / discussions / replies) - should be hidden
        • 'Expect completed on' should be shown
        • 'Expect completed on' should be enabled / disabled based on the tickbox to the right
      4. Set 'Completion tracking' to 'Show activity as complete when conditions are met'
        • 'Require view', 'Require grade', all custom automatic rules (posts / discussions / replies), 'Expect completion on' - all should be shown
        • 'Require grade' should still be enabled/disabled based on whether or not ratings are enabled
        • The number of posts / discussions / replies should be enabled/disabled base on whether or not that rule is selected
        • 'Expect completed on' should be enabled / disabled based on the tickbox to the right
      Activity grade settings
      1. Create a new 'Assignment' activity
      2. On the settings form, set the 'Grade - Type' to 'None'
        • 'Maximum grade' and 'Scale' should be hidden
        • 'Grading method', 'Grade category', 'Grade to pass' should be hidden
      3. Set 'Grade - Type' to 'Point'
        • 'Maximum grade' should be shown
        • 'Scale' select should be hidden
        • 'Grading method', 'Grade category', 'Grade to pass' should be shown
      4. Set 'Grade - Type' to 'Scale'
        • 'Maximum grade' should be hidden
        • 'Scale' select should be shown
        • 'Grading method', 'Grade category', 'Grade to pass' should be shown
      Delete course category
      1. Create a course category with at least 1 course or subcategory within it
      2. In the course and category management page, select 'Delete' from the category actions pulldown menu. A new page "Delete category: XXX" opens.
      3. Set 'What to do' to 'Move contents to another category'
        • 'Move into' select should be shown
      4. Set 'What to do' to 'Delete all - cannot be undone'
        • 'Move into' select should be hidden
      Show
      Activity grouping settings Create a new 'forum' activity On the settings form, set 'Group mode' to 'No groups' (that is the default on your system, probably) 'Grouping' setting should be hidden Set 'Group mode' to 'Separate' or 'Visible' groups 'Grouping' setting should be shown Activity ratings Create a new 'forum' activity On the settings form, set the 'Aggregate type' to 'No ratings' (that is the default on your system, probably) 'Scale' settings + 'Restrict ratings to items with dates in this range:' settings should be hidden Set 'Aggregate type' to anything other than 'No ratings' 'Scale' settings + 'Restrict ratings to items with dates in this range:' settings should be shown Activity completion Create a new 'forum' activity On the settings form, set 'Completion tracking' to 'Do not indicate' 'Require view', 'Require grade', all custom automatic rules (posts / discussions / replies), 'Expect completion on' - all should be hidden Set 'Completion tracking' to 'Students can manually mark the activity as completed' 'Require view', 'Require grade', all custom automatic rules (posts / discussions / replies) - should be hidden 'Expect completed on' should be shown 'Expect completed on' should be enabled / disabled based on the tickbox to the right Set 'Completion tracking' to 'Show activity as complete when conditions are met' 'Require view', 'Require grade', all custom automatic rules (posts / discussions / replies), 'Expect completion on' - all should be shown 'Require grade' should still be enabled/disabled based on whether or not ratings are enabled The number of posts / discussions / replies should be enabled/disabled base on whether or not that rule is selected 'Expect completed on' should be enabled / disabled based on the tickbox to the right Activity grade settings Create a new 'Assignment' activity On the settings form, set the 'Grade - Type' to 'None' 'Maximum grade' and 'Scale' should be hidden 'Grading method', 'Grade category', 'Grade to pass' should be hidden Set 'Grade - Type' to 'Point' 'Maximum grade' should be shown 'Scale' select should be hidden 'Grading method', 'Grade category', 'Grade to pass' should be shown Set 'Grade - Type' to 'Scale' 'Maximum grade' should be hidden 'Scale' select should be shown 'Grading method', 'Grade category', 'Grade to pass' should be shown Delete course category Create a course category with at least 1 course or subcategory within it In the course and category management page, select 'Delete' from the category actions pulldown menu. A new page "Delete category: XXX" opens. Set 'What to do' to 'Move contents to another category' 'Move into' select should be shown Set 'What to do' to 'Delete all - cannot be undone' 'Move into' select should be hidden
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull Master Branch:
      MDL-64557_course_hideif

      Description

      Review the forms in the course/ directory for those which are candidates for switching disabledIf() to hideIf()

      Proposed changes: course - hideif.pdf

        Attachments

        1. Activity grouping settings - no groups.png
          Activity grouping settings - no groups.png
          195 kB
        2. Activity ratings - any other settings.png
          Activity ratings - any other settings.png
          203 kB
        3. course - hideif.pdf
          503 kB
        4. MDL-64557.jpg
          MDL-64557.jpg
          57 kB
        5. MDL-64557 (2).jpg
          MDL-64557 (2).jpg
          36 kB
        6. screenshot-1.png
          screenshot-1.png
          69 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 20 minutes
                  20m