Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64561

Install database CLI script does not show help if Moodle is already installed

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Clone a new Moodle instance.
      2. Create an empty database.
      3. Run admin/cli/install.php --skip-database.
      4. Verify that config.php is populated but that the database is empty.
      5. Run admin/cli/install_database.php --help and ensure that the help text for the command is displayed.
      6. Run admin/cli/install_database.php --agree-license --adminpass=youradminpassword.
      7. Verify that the Moodle instance is installed.
      8. Run admin/cli/install_database.php --help and ensure that the help text for the command is displayed.
      Show
      Clone a new Moodle instance. Create an empty database. Run admin/cli/install.php --skip-database. Verify that config.php is populated but that the database is empty. Run admin/cli/install_database.php --help and ensure that the help text for the command is displayed. Run admin/cli/install_database.php --agree-license --adminpass=youradminpassword. Verify that the Moodle instance is installed. Run admin/cli/install_database.php --help and ensure that the help text for the command is displayed.
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
      MDL-64561-35-test
    • Pull 3.5 Diff URL:
    • Pull Master Branch:
      MDL-64561-master-test
    • Pull Master Diff URL:

      Description

      Discovered in MDLQA-12735. The cli database installation script bails out before checking parameters if tables are present. There was consensus in the linked QA task that you should always be able to get help information for a command.

        Attachments

          Issue Links

          Discovered while testing

          Functional Test - A test of a single Moodle feature MDLQA-12735 CLONE - Moodle install via CLI and web

          • Minor - Minor loss of function where workaround is possible
          • Passed
          has a clone

          Improvement - An enhancement to an existing Moodle feature. MDL-64826 Improve and fix show help of install database CLI script

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              cfulton Charles Fulton
              Reporter:
              cfulton Charles Fulton
              Peer reviewer:
              Shamim Rezaie
              Integrator:
              Andrew Nicols
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Mar/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 30 minutes
                  2h 30m