Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64576

Course completion activity dates are incorrect if course completion criteria have been edited

    XMLWordPrintable

Details

    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_36_STABLE, MOODLE_400_STABLE
    • MOODLE_310_STABLE, MOODLE_311_STABLE
    • MOODLE_311_MDL-64576
    • master-MDL-64576-v2
    • Hide

      Setup

      1. Login as an admin.
      2. Create a course and 4 users.
      3. Enrol the users in the course. For User 2, set the Enrolment start to a date 10 days ago
      4. Create an Assignment activity and set Activity completion to Student must view this activity to complete it.
      5. Login as User 1 and view the activity.
      6. Login as an admin.
      7. Access gradebook and open single user view tab.
      8. Select Course total as a grade item.
      9. Override User 3's course total grade and set it to 80.
      10. Access course completion settings page.
      11. Set Completion requirements to Course is complete when ANY of the conditions are met.
      12. Tick Assignment in the Activity completion section.
      13. Enable Enrolment duration condition and set User must remain enrolled for to 7 days.
      14. Enable Course grade condition and set Required course grade to 60.
      15. Save changes.

      Test

      1. Run the "\core\task\completion_regular_task" scheduled task twice.

        php admin/cli/scheduled_task.php --execute="\\core\\task\\completion_regular_task"

      2. Access the Course completion report.
      3. Hover on the checked items in the table.
      4. Confirm, that "Activities" and "Course" are ticked for User 1 and both completion dates (activity and course) reflect the time when the activity was viewed.
      5. Confirm, that "Days" and "Course" are ticked for User 2 and both completion dates reflect a date 3 days ago.
      6. Confirm, that "Grade" and "Course" are ticked for User 3 and both completion dates reflect the time when the user was graded.
      7. Access course completion settings page.
      8. Click Unlock completion options and delete user completion data.
      9. Save changes.
      10. Access completion report.
      11. Confirm, that the course completion data is removed.
      12. Run the "\core\task\completion_regular_task" scheduled task twice.
      13. Access the course completion report.
      14. Hover on the checked items in the table.
      15. Confirm, that "Activities" and "Course" are ticked for User 1 and both completion dates (activity and course) reflect the time when the activity was viewed.
      16. Confirm, that "Days" and "Course" are ticked for User 2 and both completion dates reflect a date 3 days ago.
      17. Confirm, that "Grade" and "Course" are ticked for User 3 and both completion dates reflect the time when the user was graded.
      18. Access course completion settings page.
      19. Click Unlock completion options and delete user completion data.
      20. Enable Date condition and set Date when course will be marked as complete to yesterday's date.
      21. Save changes.
      22. Run the "\core\task\completion_regular_task" scheduled task twice.
      23. Access completion report.
      24. Confirm, that all four users (including User 4) completed the course.
      Show
      Setup Login as an admin. Create a course and 4 users. Enrol the users in the course. For User 2, set the Enrolment start to a date 10 days ago Create an Assignment activity and set Activity completion to Student must view this activity to complete it . Login as User 1 and view the activity. Login as an admin. Access gradebook and open single user view tab. Select Course total as a grade item. Override User 3's course total grade and set it to 80. Access course completion settings page. Set Completion requirements to Course is complete when ANY of the conditions are met . Tick Assignment in the Activity completion section. Enable Enrolment duration condition and set User must remain enrolled for to 7 days. Enable Course grade condition and set Required course grade to 60. Save changes. Test Run the "\core\task\completion_regular_task" scheduled task twice. php admin/cli/scheduled_task.php --execute="\\core\\task\\completion_regular_task" Access the Course completion report. Hover on the checked items in the table. Confirm , that "Activities" and "Course" are ticked for User 1 and both completion dates (activity and course) reflect the time when the activity was viewed. Confirm , that "Days" and "Course" are ticked for User 2 and both completion dates reflect a date 3 days ago. Confirm , that "Grade" and "Course" are ticked for User 3 and both completion dates reflect the time when the user was graded. Access course completion settings page. Click Unlock completion options and delete user completion data . Save changes. Access completion report. Confirm , that the course completion data is removed. Run the "\core\task\completion_regular_task" scheduled task twice. Access the course completion report. Hover on the checked items in the table. Confirm , that "Activities" and "Course" are ticked for User 1 and both completion dates (activity and course) reflect the time when the activity was viewed. Confirm , that "Days" and "Course" are ticked for User 2 and both completion dates reflect a date 3 days ago. Confirm , that "Grade" and "Course" are ticked for User 3 and both completion dates reflect the time when the user was graded. Access course completion settings page. Click Unlock completion options and delete user completion data . Enable Date condition and set Date when course will be marked as complete to yesterday's date. Save changes. Run the "\core\task\completion_regular_task" scheduled task twice. Access completion report. Confirm , that all four users (including User 4) completed the course.

    Description

      Course completion statuses are regenerated in a course where the course completed criteria have been altered. HOWEVER, the dates for the completion are now wrong in the "Completion progress details" report. The activities are shown as complete on the date that the criteria were regenerated. The completion dates are correct in the "Outline report."

      When the course completion criteria statuses are generated, the completion date should be taken from the activity, not set to the date the statuses are generated.

      Attachments

        Issue Links

          Activity

            People

              mikhailgolenkov Misha Golenkov
              emdalton1 Elizabeth Dalton
              Matt Porritt Matt Porritt
              Victor Déniz Falcón Victor Déniz Falcón
              Gladys Basiana Gladys Basiana
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona)
              Votes:
              10 Vote for this issue
              Watchers:
              21 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                8/Nov/21

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 45 minutes
                  5h 45m