Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64590

Review attempt Response History commenting for any quiz question being replaced with latest comments

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5.2
    • Fix Version/s: 3.5.5, 3.6.3
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      The unit test included in this issue is sufficient to verify the fix, and the other unit tests are enough to verify there are no regressions.

      If you really want to test manually:

      1. Create a quiz.
      2. Add a true-false question.
      3. Attempt the quiz as a student and submit it.
      4. As teacher go and review the student's attempt.
      5. Use the 'Make comment or override mark' link to add a comment "Comment 1"
      6. Use the 'Make comment or override mark' link a second time, and change the comment to "Comment 2"
      7. Verify that In the 'Response history' table under the question, verify that you can see both comments in the history.

      (Before this change, both comment actions in the history would be shown as 'Comment 2'.

      Show
      The unit test included in this issue is sufficient to verify the fix, and the other unit tests are enough to verify there are no regressions. If you really want to test manually: Create a quiz. Add a true-false question. Attempt the quiz as a student and submit it. As teacher go and review the student's attempt. Use the 'Make comment or override mark' link to add a comment "Comment 1" Use the 'Make comment or override mark' link a second time, and change the comment to "Comment 2" Verify that In the 'Response history' table under the question, verify that you can see both comments in the history. (Before this change, both comment actions in the history would be shown as 'Comment 2'.
    • Affected Branches:
      MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull 3.6 Branch:
    • Pull Master Branch:

      Description

      Steps to Reproduce:

       

      1) Create a quiz with one written response/Multi choice question, and have a student account complete an attempt. 

      2) Review the attempt and written/Multi choice question, give it a grade and unique comment. 

      3) Revisit the attempt and written/Multi choice question, replace the first comment with another unique comment.

      4) Observe the revision history having lost your first comment, and now containing two duplicate comments at two different times. Repeating Step 3 will illustrate unique date and times, but the latest comment entered will then appear across all previous unique date and time comment updates. The older comment responses are gone. 

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                timhunt Tim Hunt
                Reporter:
                Green Patrick
                Peer reviewer:
                Simey Lameze
                Integrator:
                David Monllaó
                Tester:
                Janelle Barcega
                Participants:
                Component watchers:
                Tim Hunt, Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Mar/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 14 minutes
                  14m