Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64590

Review attempt Response History commenting for any quiz question being replaced with latest comments

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.5.5, 3.6.3
    • 3.5.2
    • Quiz
    • MOODLE_35_STABLE
    • MOODLE_35_STABLE, MOODLE_36_STABLE
    • Hide

      The unit test included in this issue is sufficient to verify the fix, and the other unit tests are enough to verify there are no regressions.

      If you really want to test manually:

      1. Create a quiz.
      2. Add a true-false question.
      3. Attempt the quiz as a student and submit it.
      4. As teacher go and review the student's attempt.
      5. Use the 'Make comment or override mark' link to add a comment "Comment 1"
      6. Use the 'Make comment or override mark' link a second time, and change the comment to "Comment 2"
      7. Verify that In the 'Response history' table under the question, verify that you can see both comments in the history.

      (Before this change, both comment actions in the history would be shown as 'Comment 2'.

      Show
      The unit test included in this issue is sufficient to verify the fix, and the other unit tests are enough to verify there are no regressions. If you really want to test manually: Create a quiz. Add a true-false question. Attempt the quiz as a student and submit it. As teacher go and review the student's attempt. Use the 'Make comment or override mark' link to add a comment "Comment 1" Use the 'Make comment or override mark' link a second time, and change the comment to "Comment 2" Verify that In the 'Response history' table under the question, verify that you can see both comments in the history. (Before this change, both comment actions in the history would be shown as 'Comment 2'.

      Steps to Reproduce:

       

      1) Create a quiz with one written response/Multi choice question, and have a student account complete an attempt. 

      2) Review the attempt and written/Multi choice question, give it a grade and unique comment. 

      3) Revisit the attempt and written/Multi choice question, replace the first comment with another unique comment.

      4) Observe the revision history having lost your first comment, and now containing two duplicate comments at two different times. Repeating Step 3 will illustrate unique date and times, but the latest comment entered will then appear across all previous unique date and time comment updates. The older comment responses are gone. 

            timhunt Tim Hunt
            Green Patrick
            Simey Lameze Simey Lameze
            David Monllaó David Monllaó
            Janelle Barcega Janelle Barcega
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 14 minutes
                14m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.