[MDL-64590] Review attempt Response History commenting for any quiz question being replaced with latest comments - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.5.2
Fix Version/s: 3.5.5, 3.6.3
Component/s: Quiz
Labels:
- ci
- triaged

Affected Branches:
MOODLE_35_STABLE
Fixed Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE
Pull from Repository:
https://github.com/timhunt/moodle
Pull Master Branch:
~~MDL-64590~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-64590
Testing Instructions:
Hide

The unit test included in this issue is sufficient to verify the fix, and the other unit tests are enough to verify there are no regressions.

If you really want to test manually:

Create a quiz.

Add a true-false question.

Attempt the quiz as a student and submit it.

As teacher go and review the student's attempt.

Use the 'Make comment or override mark' link to add a comment "Comment 1"

Use the 'Make comment or override mark' link a second time, and change the comment to "Comment 2"

Verify that In the 'Response history' table under the question, verify that you can see both comments in the history.

(Before this change, both comment actions in the history would be shown as 'Comment 2'.
Show
The unit test included in this issue is sufficient to verify the fix, and the other unit tests are enough to verify there are no regressions. If you really want to test manually: Create a quiz. Add a true-false question. Attempt the quiz as a student and submit it. As teacher go and review the student's attempt. Use the 'Make comment or override mark' link to add a comment "Comment 1" Use the 'Make comment or override mark' link a second time, and change the comment to "Comment 2" Verify that In the 'Response history' table under the question, verify that you can see both comments in the history. (Before this change, both comment actions in the history would be shown as 'Comment 2'.

Description

Steps to Reproduce:

1) Create a quiz with one written response/Multi choice question, and have a student account complete an attempt.

2) Review the attempt and written/Multi choice question, give it a grade and unique comment.

3) Revisit the attempt and written/Multi choice question, replace the first comment with another unique comment.

4) Observe the revision history having lost your first comment, and now containing two duplicate comments at two different times. Repeating Step 3 will illustrate unique date and times, but the latest comment entered will then appear across all previous unique date and time comment updates. The older comment responses are gone.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

screenshot-1.png
38 kB
13/Feb/19 9:32 AM
Before_NewCommentOverriddingOldComments.jpg
200 kB
16/Jan/19 4:42 AM
After_NewCommentOverriddingOldComments.jpg
237 kB
16/Jan/19 4:42 AM

Issue Links

is a regression caused by

MDL-41090 Allow teachers to embed files when manually grading questions

Closed

Activity

People

Assignee:: Tim Hunt

Reporter:: Patrick

Peer reviewer:: Simey Lameze

Integrator:: David Monllaó

Tester:: Janelle Barcega

Participants:: CiBoT, David Monllaó, Janelle Barcega, Patrick, Simey Lameze, Tim Hunt

Component watchers:: Tim Hunt, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 16/Jan/19 4:42 AM

Updated:: 15/Feb/19 9:47 AM

Resolved:: 15/Feb/19 9:47 AM

Fix Release Date:: 11/Mar/19

Time Tracking

Estimated:

Remaining:

Logged:

14m