[MDL-64599] Any unit test that calls createArrayDataSet() fails - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.5.4, 3.6.2, 3.7
Fix Version/s: 3.5.5, 3.6.3
Component/s: Unit tests
Labels:
- CatalystIT
- ci
- partner
- patch

Testing Instructions:
Hide

Install mod_collaborate (https://moodle.org/plugins/mod_collaborate)

Re-initialise phpunit:

php admin/tool/phpunit/cli/init.php

Run the mod_collaborate testsuit:

./vendor/bin/phpunit --testsuite mod_collaborate_testsuite

Confirm success
Show
Install mod_collaborate ( https://moodle.org/plugins/mod_collaborate ) Re-initialise phpunit: php admin/tool/phpunit/cli/init.php Run the mod_collaborate testsuit: ./vendor/bin/phpunit --testsuite mod_collaborate_testsuite Confirm success
Affected Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE
Pull from Repository:
https://github.com/marcusboon/moodle
Pull 3.5 Branch:
M3.5-~~MDL-64599~~
Pull 3.5 Diff URL:
https://github.com/moodle/moodle/compare/b39f719...marcusboon:M3.5-MDL-64599
Pull Master Branch:
~~MDL-64599~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/c092f75...marcusboon:MDL-64599

Description

mod_collaborate has a unit test that does exactly this. And it fails with:

1) mod_collaborate_recording_counter_testcase::test_get_recording_counts
Error: Class 'PHPUnit\DbUnit\DataSet\DefaultTableMetaData' not found
/home/marcus/workspace/latrobe/lib/phpunit/classes/arraydataset.php:61
/home/marcus/workspace/latrobe/lib/phpunit/classes/advanced_testcase.php:190
/home/marcus/workspace/latrobe/mod/collaborate/tests/recording_counter_test.php:56
/home/marcus/workspace/latrobe/lib/phpunit/classes/advanced_testcase.php:80

To re-run: vendor/bin/phpunit "mod_collaborate_recording_counter_testcase" mod/collaborate/tests/recording_counter_test.php

We first thought the issue was with a non-properly installed DbUnit but upon digging further, it's a typo in core which is causing this issue.

Attachments

Issue Links

Testing discovered

MDL-64600 Prepare for removal of PHPUnit/DbUnit

Closed

Activity

People

Assignee:: Marcus Boon

Reporter:: Marcus Boon

Peer reviewer:: Andrew Nicols

Integrator:: Eloy Lafuente (stronk7)

Tester:: Shamim Rezaie

Participants:: Andrew Nicols, CiBoT, Eloy Lafuente (stronk7), Marcus Boon, Shamim Rezaie

Component watchers:: Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 16/Jan/19 1:46 PM

Updated:: 15/Feb/19 9:47 AM

Resolved:: 15/Feb/19 9:47 AM

Fix Release Date:: 11/Mar/19