-
Type:
Bug
-
Status: Waiting for peer review
-
Priority:
Minor
-
Resolution: Unresolved
-
Affects Version/s: 3.5.2, 3.5.3, 3.5.4, 3.6, 3.6.1, 3.6.2, 3.7, 3.8.5, 3.9.2
-
Fix Version/s: None
-
Component/s: Enrolments
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
-
Pull from Repository:
-
Pull Master Branch:MDL-64648-master_enrol_manual_notify_expires_default
-
Story Points:3
-
Sprint:Moppies Moodle 3.8 Sprint 1, Moppies Moodle 3.8 Sprint 2, Moppies Moodle 3.8 Sprint 3, Moppies Moodle 3.8 Sprint 4, Moppies Moodle 3.8 Sprint 5, Moppies Moodle 3.8 Sprint 6
When creating a new course with manual enrollments enabled, if the manual enrolment plugin
Notify before enrolment expires (enrol_manual | expirynotify) setting is set to "Enroller + Enrolled" (or the new "Teacher + Enrolled user" language string in 3.6), the course manual enrollment instance will default to "Enroller". You would expect it to be set to "Enroller + Enrolled" to match the default.
This looks to be caused by the call to add_default_instance in https://github.com/moodle/moodle/blob/master/enrol/manual/lib.php#L128. It looks like the code was borrowed from get_instance_defaults in the the self-enrol plugin (https://github.com/moodle/moodle/blob/master/enrol/self/lib.php#L337), which correctly sets the course expirynotify to Enroller since, in Self-Enrol, the Enroller and Enrolled are the same person, and you would not want them to receive two notifications.
- will be (partly) resolved by
-
-
- Open
-
