Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64682

Courses past navcourselimit ignore showallcourses in navigation

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Reopened
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.5.2, 3.6.2
    • Fix Version/s: None
    • Component/s: Navigation
    • Labels:
    • Testing Instructions:
      Hide

      Test using Classic theme for 3.7 and master, and Clean theme for 3.6

      Before patch (using latest release)

      1. Set navcourselimit to 2 (Settings > Appearance > Navigation)
      2. Create 3 courses and enrol a user in each of them.
      3. Log in as the user enrolled in the previous step.
      4. Verify that 2 courses (from the 3 created) are shown under "My courses". There is a 3rd course not shown at all.
      5. Navigate to the 3rd course that does not appear under "My Courses" in the Navigation block (you can do this by going to the dashboard and then going to that 3rd course).
      6. Verify that the 3 courses appears under "My courses", with current one in bold (i.e. the navcourselimit is not observed).

      after patch (using integration.git current branches)

      1. Reload the course page in the previous step.
      2. Verify that 2 courses appears under "My courses" (i.e. the navcourselimit IS observed). The current course appears under "Current Course", instead of "My courses".
      3. Navigate to any of the 2 courses under "My Courses".
      4. Verify that the 2 courses appear under "My courses" with the one being the current one in bold.
      Show
      Test using Classic theme for 3.7 and master, and Clean theme for 3.6 Before patch (using latest release) Set navcourselimit to 2 (Settings > Appearance > Navigation) Create 3 courses and enrol a user in each of them. Log in as the user enrolled in the previous step. Verify that 2 courses (from the 3 created) are shown under "My courses". There is a 3rd course not shown at all. Navigate to the 3rd course that does not appear under "My Courses" in the Navigation block (you can do this by going to the dashboard and then going to that 3rd course). Verify that the 3 courses appears under "My courses", with current one in bold (i.e. the navcourselimit is not observed). after patch (using integration.git current branches) Reload the course page in the previous step. Verify that 2 courses appears under "My courses" (i.e. the navcourselimit IS observed). The current course appears under "Current Course", instead of "My courses". Navigate to any of the 2 courses under "My Courses". Verify that the 2 courses appear under "My courses" with the one being the current one in bold.
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.6 Branch:
    • Pull 3.7 Branch:
    • Pull Master Branch:
      MDL-64682-master

      Description

      What Happens

      Let's say you have a course "Intermediate Bread Buttering", which, based on the navcourselimit setting and the sorting of the My Courses navigation section, does not appear in the My Courses menu. That is, it would appear after the end of the My Courses list because of navcourselimit. If a user enrolled in that course navigates to the course page, the course is added to the navigation, but under Courses instead of My Courses, regardless of the value of showallcourses.

      Why It's Bad

      This causes MDL-60312. Additionally, for courses in which the user is enrolled, it causes full category breadcrumbs to display even if navshowmycategories is disabled (and the admin would therefore be expecting flat breadcrumbs).

      Even if those issues were resolved, it is still a violation of the expectations of the administrator who has chosen to disable showallcourses.

      Solutions?

      Apart from solving MDL-60312 and the breadcrumb issue, which exacerbate this bug, possible modifications that ameliorate this problem might be:

      1. Update the help documentation to indicate this behavior to admins
      2. On the course page of a course which exceeds navcourselimit, add that course to the navigation at the top of My Courses temporarily
      3. Do not add a current course to the navigation structure if that course is past navcourselimit

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 20 minutes
                  1h 20m