Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64694

the report insights column size does not look natural in boost

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5.4, 3.6.2, 3.7
    • Fix Version/s: 3.5.5, 3.6.3
    • Component/s: Analytics, Themes
    • Labels:
    • Testing Instructions:
      Hide

      Test using both boost and clean.

      1. Install https://github.com/dmonllao/moodle-local_testanalytics
      2. Log in as admin
      3. Create a couple of users if you don't have any
      4. Go to Site admin > Analytics > Analytics models
      5. Disable "Linear" model
      6. Execute this in the CLI:

        php admin/tool/task/cli/schedule_task.php --execute=\\tool_analytics\\task\\train_models
        php admin/tool/task/cli/schedule_task.php --execute=\\tool_analytics\\task\\predict_models
        

      7. Go to Site admin > Analytics > Analytics models
      8. Select one of the users in "Inactive users" model, "Insights" column
      9. Click on "Actions > View prediction details"
      10. You will see three different tables. There shouldn't be unnecessary line jumps in the text contained in cells and the size of the cells should be reasonable.
      Show
      Test using both boost and clean. Install https://github.com/dmonllao/moodle-local_testanalytics Log in as admin Create a couple of users if you don't have any Go to Site admin > Analytics > Analytics models Disable "Linear" model Execute this in the CLI: php admin/tool/task/cli/schedule_task.php --execute=\\tool_analytics\\task\\train_models php admin/tool/task/cli/schedule_task.php --execute=\\tool_analytics\\task\\predict_models Go to Site admin > Analytics > Analytics models Select one of the users in "Inactive users" model, "Insights" column Click on "Actions > View prediction details" You will see three different tables. There shouldn't be unnecessary line jumps in the text contained in cells and the size of the cells should be reasonable.
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-64694_master

      Description

      report_insights templates are using col-X-Y classes and those were not made compatible with bs4stable. We need to replace them with an alternative that is compatible with both clean and boost, or to use the default col size provided by flexible tables.

        Attachments

        1. after-patch.png
          after-patch.png
          46 kB
        2. before-patch.png
          before-patch.png
          34 kB
        3. MDL-64694-boost-test.png
          MDL-64694-boost-test.png
          45 kB
        4. MDL-64694-clean-test.png
          MDL-64694-clean-test.png
          34 kB

          Activity

            People

            Assignee:
            dmonllao David Monllaó
            Reporter:
            dmonllao David Monllaó
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Michael Hawkins
            Participants:
            Component watchers:
            Elizabeth Dalton, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Mar/19

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 45 minutes
                45m