Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64696

Possible to create duplicate Oauth2 field mappings

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Development in progress
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.5.4, 3.6.2, 3.7
    • Fix Version/s: None
    • Component/s: Authentication
    • Labels:
    • Testing Instructions:
      Hide
      1. Setup a Google OAuth2 service
      2. Go to user field mappings edit page
      3. Try to add new user field mapping with external field value that already exists
        1. Make sure that error message appears after saving and nothing is saved
      4. Try to add new user field mapping with external field value that does not already exist
        1. Make sure that mapping is added successfully
      5. Try to edit existing user field mapping and set external value to an existing external value
        1. Make sure that error message appears after saving and nothing is saved
      Show
      Setup a Google OAuth2 service Go to user field mappings edit page Try to add new user field mapping with external field value that already exists Make sure that error message appears after saving and nothing is saved Try to add new user field mapping with external field value that does not already exist Make sure that mapping is added successfully Try to edit existing user field mapping and set external value to an existing external value Make sure that error message appears after saving and nothing is saved
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-64696-master
    • Pull Master Diff URL:

      Description

      When creating field mappings for OAuth2 authentication external field can be specified more times. This has unpredictable behavior for admin, because only last mapping for that external field is used(fields are stored as associative array with external field name as key).

        Attachments

          Activity

            People

            • Assignee:
              mastnym Martin Mastny
              Reporter:
              mastnym Martin Mastny
              Peer reviewer:
              Damyon Wiese
              Participants:
              Component watchers:
              Jake Dallimore, Jun Pataleta
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m