[MDL-64743] block_myoverview: Remove icons from course context menu (Was: Starred courses should get a "unstar" icon in their context menu) - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.6
Fix Version/s: 3.8
Component/s: Dashboard (My home)
Labels:
- ci
- triaged

Affected Branches:
MOODLE_36_STABLE
Fixed Branches:
MOODLE_38_STABLE
Epic Link:
Improvements to the Dashboard and Course Overview page
Pull from Repository:
git://github.com/abias/moodle.git
Pull Master Branch:
~~MDL-64743~~-master
Pull Master Diff URL:
https://github.com/abias/moodle/compare/a713ed3ba6...MDL-64743-master
Testing Instructions:
Hide

Verify removed icons

Login as a user who is enrolled in at least one course

Go to the Dashboard and look at your course overview block

Open a course's context menu

Use the "Star this course" / "Unstar this course" / "Hide this course" / "Show this course" menu items to toggle all possible status permutations.

Expected result:
The context menu items are never prefixed by any icon
Show
Verify removed icons Login as a user who is enrolled in at least one course Go to the Dashboard and look at your course overview block Open a course's context menu Use the "Star this course" / "Unstar this course" / "Hide this course" / "Show this course" menu items to toggle all possible status permutations. Expected result: The context menu items are never prefixed by any icon

Description

In the course overview block, courses can be starred which is a great feature.
If a course is not starred yet, in the context menu of the course, there is an entry "star this course" which has a star icon.
If a course is already starred, in the context menu of the course, there is an entry "unstar this course" which hasn't an icon. This is inconsistent.

I would propose to add a the fa-star-o icon to the "unstar this course" menu item.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Confirmed and verified fixed.png
109 kB
11/Jun/19 10:40 AM
Screenshot_31_01_19__14_35.png
42 kB
31/Jan/19 9:36 PM

Activity

People

Assignee:: Alexander Bias

Reporter:: Alexander Bias

Peer reviewer:: Simey Lameze

Integrator:: Adrian Greeve

Tester:: Gladys Basiana

Participants:: Adrian Greeve, Alexander Bias, Andrew Lyons, Barbara Ramiro, CiBoT, Eloy Lafuente (stronk7), Gladys Basiana, Simey Lameze

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 31/Jan/19 9:36 PM

Updated:: 18/Jun/19 6:54 PM

Resolved:: 14/Jun/19 12:34 AM

Fix Release Date:: 18/Nov/19

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

30m