Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64743

block_myoverview: Remove icons from course context menu (Was: Starred courses should get a "unstar" icon in their context menu)

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6
    • Fix Version/s: 3.8
    • Component/s: Dashboard (My home)
    • Labels:
    • Testing Instructions:
      Hide

      Verify removed icons

      • Login as a user who is enrolled in at least one course
      • Go to the Dashboard and look at your course overview block
      • Open a course's context menu
      • Use the "Star this course" / "Unstar this course" / "Hide this course" / "Show this course" menu items to toggle all possible status permutations.

      Expected result:
      The context menu items are never prefixed by any icon

      Show
      Verify removed icons Login as a user who is enrolled in at least one course Go to the Dashboard and look at your course overview block Open a course's context menu Use the "Star this course" / "Unstar this course" / "Hide this course" / "Show this course" menu items to toggle all possible status permutations. Expected result: The context menu items are never prefixed by any icon
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-64743-master

      Description

      In the course overview block, courses can be starred which is a great feature.
      If a course is not starred yet, in the context menu of the course, there is an entry "star this course" which has a star icon.
      If a course is already starred, in the context menu of the course, there is an entry "unstar this course" which hasn't an icon. This is inconsistent.

      I would propose to add a the fa-star-o icon to the "unstar this course" menu item.

        Attachments

        1. Confirmed and verified fixed.png
          109 kB
          Gladys Basiana
        2. Screenshot_31_01_19__14_35.png
          42 kB
          Alexander Bias

          Activity

            People

            Assignee:
            abias Alexander Bias
            Reporter:
            abias Alexander Bias
            Peer reviewer:
            Simey Lameze Simey Lameze
            Integrator:
            Adrian Greeve Adrian Greeve
            Tester:
            Gladys Basiana Gladys Basiana
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              18/Nov/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m