Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64757

Some Dashboard elements are following browser language, not page language

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Install a language pack other than English
      2. Set the Moodle 'Default language' to that language (Site Administration > Language Settings) and ensure 'Language autodetect' is checked
      3. Create a test course with an assignment and a test user
      4. In the test course enable Completion tracking in settings
      5. In the test assignment of that course set 'Completion tracking' to 'Students can manually mark the activity as completed'
      6. Enrol the test user in the test course and login as that user
      7. As the user, select 'English' from the language dropdown on the top left
      8. Navigate to the 'Dashboard'
      9. Test course should be visible in 'Course overview' and it should have a completion bar with '0% complete' (in English)
      10. Click on the three dot context menu, you should see 'Star this course' and 'Hide from view' in English too.
      11. Change the language to installed language from the dropdown top left
      12. These items you previously checked should be in the language you changed to.
      Show
      Install a language pack other than English Set the Moodle 'Default language' to that language ( Site Administration > Language Settings ) and ensure 'Language autodetect' is checked Create a test course with an assignment and a test user In the test course enable Completion tracking in settings In the test assignment of that course set 'Completion tracking' to 'Students can manually mark the activity as completed' Enrol the test user in the test course and login as that user As the user, select 'English' from the language dropdown on the top left Navigate to the 'Dashboard' Test course should be visible in 'Course overview' and it should have a completion bar with '0% complete' (in English) Click on the three dot context menu, you should see 'Star this course' and 'Hide from view' in English too. Change the language to installed language from the dropdown top left These items you previously checked should be in the language you changed to.
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull 3.7 Branch:
      MDL-64757-37_core_output_nested_template_block_string_language
    • Pull 3.7 Diff URL:
    • Pull Master Branch:
      MDL-64757-38_core_output_nested_template_block_string_language
    • Pull Master Diff URL:

      Description

      If you switch the language of your Moodle page (have more than one language pack installed) then some dashboard elements don't change along.

      They seem to stick with the browser language. If you change the preferred browser language, those elements will differ from that no matter what Moodle language is chosen.
      You can verify this on https://qa.moodle.net.

      Steps to replicate:

      • Open your browser's settings and set the preferred website language to something != English (in our example: German). The browser's preferred language is now german.
      • Go to https://qa.moodle.net.
      • Login as teacher.
      • Make sure that your selected Moodle language is english. You expect all UI elements to be in english now.
      • Have a look at the course overview block.
      • Open the three-dot context menu of any course.

      Expected result:

      • The context menu items are listed in English

      Actual result:

      • The context menu items are listed in German
      • See

      That apparently concerns mustache templates called from within mustache templates e.g.

      > block_myoverview/progress-bar

      > block_myoverview/course-action-menu

      called by blocks/myoverview/templates/view-summary.mustache.

        Attachments

        1. master.jpg
          master.jpg
          16 kB
        2. MDL-64757.jpg
          MDL-64757.jpg
          30 kB
        3. MDL-64757.png
          MDL-64757.png
          652 kB
        4. MDL-64757-take2.png
          MDL-64757-take2.png
          520 kB

          Issue Links

          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-64348 Improve ajax template fetching

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              tom_d Tom Dickman
              Reporter:
              lucaboesch Luca Bösch
              Peer reviewer:
              Andrew Madden
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Sep/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 25 minutes
                  5h 25m