[MDL-64757] Some Dashboard elements are following browser language, not page language - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.7, 3.8
Fix Version/s: 3.7.2
Component/s: Dashboard (My home)
Labels:

Affected Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Fixed Branches:
MOODLE_37_STABLE
Epic Link:
Improvements to the Dashboard and Course Overview page
Pull from Repository:
https://github.com/tomdickman/moodle
Pull Master Branch:
~~MDL-64757~~-38_core_output_nested_template_block_string_language
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...tomdickman:MDL-64757-38_core_output_nested_template_block_string_language
Testing Instructions:
Hide

Install a language pack other than English

Set the Moodle 'Default language' to that language (Site Administration > Language Settings) and ensure 'Language autodetect' is checked

Create a test course with an assignment and a test user

In the test course enable Completion tracking in settings

In the test assignment of that course set 'Completion tracking' to 'Students can manually mark the activity as completed'

Enrol the test user in the test course and login as that user

As the user, select 'English' from the language dropdown on the top left

Navigate to the 'Dashboard'

Test course should be visible in 'Course overview' and it should have a completion bar with '0% complete' (in English)

Click on the three dot context menu, you should see 'Star this course' and 'Hide from view' in English too.

Change the language to installed language from the dropdown top left

These items you previously checked should be in the language you changed to.
Show
Install a language pack other than English Set the Moodle 'Default language' to that language ( Site Administration > Language Settings ) and ensure 'Language autodetect' is checked Create a test course with an assignment and a test user In the test course enable Completion tracking in settings In the test assignment of that course set 'Completion tracking' to 'Students can manually mark the activity as completed' Enrol the test user in the test course and login as that user As the user, select 'English' from the language dropdown on the top left Navigate to the 'Dashboard' Test course should be visible in 'Course overview' and it should have a completion bar with '0% complete' (in English) Click on the three dot context menu, you should see 'Star this course' and 'Hide from view' in English too. Change the language to installed language from the dropdown top left These items you previously checked should be in the language you changed to.

Description

If you switch the language of your Moodle page (have more than one language pack installed) then some dashboard elements don't change along.

They seem to stick with the browser language. If you change the preferred browser language, those elements will differ from that no matter what Moodle language is chosen.
You can verify this on https://qa.moodle.net.

Steps to replicate:

Open your browser's settings and set the preferred website language to something != English (in our example: German). The browser's preferred language is now german.
Go to https://qa.moodle.net.
Login as teacher.
Make sure that your selected Moodle language is english. You expect all UI elements to be in english now.
Have a look at the course overview block.
Open the three-dot context menu of any course.

Expected result:

The context menu items are listed in English

Actual result:

The context menu items are listed in German
See

That apparently concerns mustache templates called from within mustache templates e.g.

> block_myoverview/progress-bar

> block_myoverview/course-action-menu

called by blocks/myoverview/templates/view-summary.mustache.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

master.jpg
16 kB
07/Aug/19 5:14 PM
MDL-64757.jpg
30 kB
08/Aug/19 3:30 PM
MDL-64757.png
652 kB
03/Feb/19 7:08 PM
MDL-64757-take2.png
520 kB
23/May/19 1:06 PM

Issue Links

is a regression caused by

MDL-64348 Improve ajax template fetching

Closed

Activity

People

Assignee:: Tom Dickman

Reporter:: Luca Bösch

Peer reviewer:: Andrew Madden

Integrator:: Eloy Lafuente (stronk7)

Tester:: Anna Carissa Sadia

Participants:: Alexander Bias, Andrew Madden, Anna Carissa Sadia, CiBoT, Dmitrii Metelkin, Eloy Lafuente (stronk7), Janelle Barcega, Luca Bösch, Sara Arjona (@sarjona), Tom Dickman

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 8 Start watching this issue

Dates

Created:: 03/Feb/19 7:05 PM

Updated:: 05/Sep/19 12:36 AM

Resolved:: 09/Aug/19 4:55 PM

Fix Release Date:: 9/Sep/19

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

5h 25m