Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64774

WS update_user does not allow update for user if difference in capitalization

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Unit tests cover this.

      Our CI infrastructure runs on DBs which are all case-sensitive.
      You will need to install Moodle with a case-insensitive collation to test this. All other cases are already covered.

      Note: Easier to test with MDK.

      DB with case-sensitive collation
      1. Set up a database with a case-sensitive collation (e.g. PostgreSQL)
        • If using MDK: mdk install -e pgsql
      2. Confirm that the following test passes.

        mdk phpunit -r -u user/tests/externallib_test.php
        

      DB with case-insensitive collation
      1. Set up a database with case-insensitive collation (e.g. MySQL with a collation of utf8mb4_unicode_ci)
        • If using MDK: mdk install -e mysqli
      2. Confirm that the following test passes.

        mdk phpunit -r -u user/tests/externallib_test.php
        

      Show
      Unit tests cover this. Our CI infrastructure runs on DBs which are all case-sensitive. You will need to install Moodle with a case-insensitive collation to test this. All other cases are already covered. Note: Easier to test with MDK. DB with case-sensitive collation Set up a database with a case-sensitive collation (e.g. PostgreSQL) If using MDK: mdk install -e pgsql Confirm that the following test passes. mdk phpunit -r -u user/tests/externallib_test.php DB with case-insensitive collation Set up a database with case-insensitive collation (e.g. MySQL with a collation of utf8mb4_unicode_ci) If using MDK: mdk install -e mysqli Confirm that the following test passes. mdk phpunit -r -u user/tests/externallib_test.php
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull 3.5 Branch:
    • Pull 3.6 Branch:
    • Pull Master Branch:
      MDL-64774-master

      Description

      Consider the following scenario: 

       

      1. A user exists with firstname "John" , and email john@xx.com
      2. The user is updated through the webservice to firstname "John H" and email John@xx.com

      Result:

      The user is not updated and no error message is displayed. 

       

      Expected result: 

      The user user updated with firstname "John H" and email "John@xx.com" 

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Mar/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 30 minutes
                  1d 30m