Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64791

Bring back the 'messagecontactrequests" message provider triggering code

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6.2, 3.7
    • Fix Version/s: 3.6.3
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide
      1. Install and enable mailcatcher or mailhog or have your Moodle correctly configured to send emails or use a SMTP server
      2. Enable Messaging in Moodle advanced features
      3. Enable "Allow site-wide messaging" in the same page
      4. Create or use two existing users: u1 and u2 (with real email address if using a real SMTP server)
      5. Log-in as a u2, go to the "Messages" icon (top right), open the settings via the cog and select "You can restrict who can message you" -> My contacts only
      6. As u2, go to your Profile -> Preferences -> Notification preferences and check that for the "Message contact requests notification" fiel the column e-mail is set to On / On
      7. Log-in as u1, go to the "Messages" icon -> Contacts -> look for u1 by name, and add him as a contact
      8. Check that you receive an email for u2 indicating that u1 wants to add you as contact
      Show
      Install and enable mailcatcher or mailhog or have your Moodle correctly configured to send emails or use a SMTP server Enable Messaging in Moodle advanced features Enable "Allow site-wide messaging" in the same page Create or use two existing users: u1 and u2 (with real email address if using a real SMTP server) Log-in as a u2, go to the "Messages" icon (top right), open the settings via the cog and select "You can restrict who can message you" -> My contacts only As u2, go to your Profile -> Preferences -> Notification preferences and check that for the "Message contact requests notification" fiel the column e-mail is set to On / On Log-in as u1, go to the "Messages" icon -> Contacts -> look for u1 by name, and add him as a contact Check that you receive an email for u2 indicating that u1 wants to add you as contact
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.6 Branch:
    • Pull Master Branch:
      MDL-64791-master

      Description

      While working on improving push notifications in the app and I checked all the different type of messages that the system sends - message providers - (lib/db/messages.php).

      I noticed that there is a messagecontactrequests listed there (and in the Moodle in notification user preferences) but the code doing the actual sending was removed: see https://github.com/moodle/moodle/commit/0866b336353211400d46e56d3d605d8ef1906540#diff-ce6a4b4c4e8ec28e71914dd00671675eR2157

      Ryan Wyllie confirmed that seems to be a bug so I'm opening this issue

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Mar/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 35 minutes
                  35m