[MDL-64791] Bring back the 'messagecontactrequests" message provider triggering code - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.6.2, 3.7
Fix Version/s: 3.6.3
Component/s: Messages
Labels:
- ci
- triaged

Affected Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_36_STABLE
Epic Link:
Group messaging follow ups for 3.7
Pull from Repository:
git://github.com/jleyva/moodle.git
Pull Master Branch:
~~MDL-64791~~-master
Pull Master Diff URL:
https://github.com/jleyva/moodle/compare/a62e275984...MDL-64791-master
Testing Instructions:
Hide

Install and enable mailcatcher or mailhog or have your Moodle correctly configured to send emails or use a SMTP server

Enable Messaging in Moodle advanced features

Enable "Allow site-wide messaging" in the same page

Create or use two existing users: u1 and u2 (with real email address if using a real SMTP server)

Log-in as a u2, go to the "Messages" icon (top right), open the settings via the cog and select "You can restrict who can message you" -> My contacts only

As u2, go to your Profile -> Preferences -> Notification preferences and check that for the "Message contact requests notification" fiel the column e-mail is set to On / On

Log-in as u1, go to the "Messages" icon -> Contacts -> look for u1 by name, and add him as a contact

Check that you receive an email for u2 indicating that u1 wants to add you as contact
Show
Install and enable mailcatcher or mailhog or have your Moodle correctly configured to send emails or use a SMTP server Enable Messaging in Moodle advanced features Enable "Allow site-wide messaging" in the same page Create or use two existing users: u1 and u2 (with real email address if using a real SMTP server) Log-in as a u2, go to the "Messages" icon (top right), open the settings via the cog and select "You can restrict who can message you" -> My contacts only As u2, go to your Profile -> Preferences -> Notification preferences and check that for the "Message contact requests notification" fiel the column e-mail is set to On / On Log-in as u1, go to the "Messages" icon -> Contacts -> look for u1 by name, and add him as a contact Check that you receive an email for u2 indicating that u1 wants to add you as contact

Description

While working on improving push notifications in the app and I checked all the different type of messages that the system sends - message providers - (lib/db/messages.php).

I noticed that there is a messagecontactrequests listed there (and in the Moodle in notification user preferences) but the code doing the actual sending was removed: see https://github.com/moodle/moodle/commit/0866b336353211400d46e56d3d605d8ef1906540#diff-ce6a4b4c4e8ec28e71914dd00671675eR2157

Ryan Wyllie confirmed that seems to be a bug so I'm opening this issue

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

MDL-64791.jpg
22 kB
20/Feb/19 9:47 AM

Issue Links

caused a regression

MDL-65586 Not found error: message/pendingcontactrequests.php file doesn't exist anymore

Closed

Activity

People

Assignee:: Juan Leyva

Reporter:: Juan Leyva

Peer reviewer:: Ryan Wyllie

Integrator:: Eloy Lafuente (stronk7)

Tester:: Anna Carissa Sadia

Participants:: Anna Carissa Sadia, CiBoT, Eloy Lafuente (stronk7), Juan Leyva, Ryan Wyllie

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 06/Feb/19 6:01 PM

Updated:: 13/May/19 8:58 PM

Resolved:: 22/Feb/19 1:51 PM

Fix Release Date:: 11/Mar/19

Time Tracking

Estimated:

Remaining:

Logged:

35m