[MDL-64799] Backport to 3.4.x? MDL-63260 Duplicating quiz with random question has exponential questions growth - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.4.7
Fix Version/s: 3.4.8
Component/s: Backup, Questions
Labels:

Testing Instructions:
Hide

Copied from ~~MDL-63260~~.

Log in as a teacher in a course.

Create a course

Turn editing on.

Create a quiz

Edit the quiz and add a new True/false question under the course's default question category.

Add a "random question" to the quiz using the course's default question category

Go back to the course page

Duplicate the quiz

Duplicate the quiz again

Duplicate the quiz yet again

Check the question table on the database. (It's most likely mdl_question). You should see 9 questions on the table.

Open a terminal, go to your Moodle instance's root directory and run

php admin/tool/task/cli/schedule_task.php --execute=\\qtype_random\\task\\remove_unused_questions

Confirm that you see a message that 4 unused random questions have been cleaned up.

Check the question table.

Confirm that only 5 questions now remain.
Show
Copied from MDL-63260 . Log in as a teacher in a course. Create a course Turn editing on. Create a quiz Edit the quiz and add a new True/false question under the course's default question category. Add a "random question" to the quiz using the course's default question category Go back to the course page Duplicate the quiz Duplicate the quiz again Duplicate the quiz yet again Check the question table on the database. (It's most likely mdl_question). You should see 9 questions on the table. Open a terminal, go to your Moodle instance's root directory and run php admin/tool/task/cli/schedule_task.php --execute=\\qtype_random\\task\\remove_unused_questions Confirm that you see a message that 4 unused random questions have been cleaned up. Check the question table. Confirm that only 5 questions now remain.
Affected Branches:
MOODLE_34_STABLE
Fixed Branches:
MOODLE_34_STABLE
Pull from Repository:
https://github.com/timhunt/moodle.git

Description

~~MDL-45851~~ was a nasty regression that I caused (sorry). That went in to 3.4.5, but the fix ~~MDL-63260~~ only got into in 3.5.x and later.

Given the ability of the regression to break people's Moodle sites (see, for example, https://moodle.org/mod/forum/discuss.php?d=382167), I think we should consider back-porting this fix. This is not a security issue (3.4.x is security-only support) but if there was a bug that let a hacker break a user's site, we would patch it. Well, this is a bug where a Moodle developer's actions can break people's Moodle sites.

(Note, I have not tested the new code in 3.4, but basically it is a new scheduled task so it should be fine. The test script from before can be reused.)

Thanks for considering this.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

MDL-64799.jpg
06/Mar/19 10:24 AM
57 kB
Anna Carissa Sadia

Issue Links

has a non-specific relationship to

MDL-63260 Duplicating quiz with random question has exponential questions growth

Closed

Activity

People

Assignee:: Tim Hunt

Reporter:: Tim Hunt

Integrator:: Jun Pataleta

Tester:: Anna Carissa Sadia

Participants:: Anna Carissa Sadia, CiBoT, Eloy Lafuente (stronk7), Jun Pataleta, Lawrence N, Tim Hunt

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 08/Feb/19 1:02 AM

Updated:: 12/Mar/19 10:19 PM

Resolved:: 08/Mar/19 12:55 AM

Fix Release Date:: 11/Mar/19

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 30m