Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64809

OneDrive Repo does not handle special character when creating access controlled links

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Peer review in progress
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 3.6.2, 3.7.7
    • Fix Version/s: None
    • Component/s: Repositories
    • Testing Instructions:
      Hide

      As admin/teacher

      Create a category with name name Dånish
      Add a course in the category. Enroll student
      Add two assignemnts (1 and 2) with file submission enabled.
      As student:

      Add file to assignment 1 as access controlled link
      As admin

      2. Flush Onedrive cache store (repository_onedrive)

      As student:

      1, Add file to assignment 2 as access controlled link

      Expected result: The file was placed in the system OneDrive account.

      (Previously an error was displayed:The specified item name already exists. )

      Show
      As admin/teacher Create a category with name name Dånish Add a course in the category. Enroll student Add two assignemnts (1 and 2) with file submission enabled. As student: Add file to assignment 1 as access controlled link As admin 2. Flush Onedrive cache store (repository_onedrive) As student: 1, Add file to assignment 2 as access controlled link Expected result: The file was placed in the system OneDrive account. (Previously an error was displayed:The specified item name already exists. )
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull Master Branch:

      Description

      The OneDrive repo does not handle special characters such as æøå  etc 

      Make sure OneDrive repo is activated with option to hand in assignments as access controlled links meaning that a system onedrive account is connected to the O365 oAuth settings. 

      Steps to reproduce: 

      As admin/teacher

      1. Create a category with name name Dånish 
      2. Add a course in the category. Enroll student  
      3. Add two assignemnts (1 and 2) with file submission enabled. 

      As student: 

      1. Add file to assignment 1 as access controlled link 

      As admin

       2. Flush Onedrive cache store  (repository_onedrive) 

      As student: 

      1, Add file to assignment 2 as access controlled link 

       

      Result: Error message is displayed : The specified item name already exists. 

      Expected result: The file was placed in the system OneDrive account. 

       

      The error is due to wrong encoding of special characters when creating the OneDrive folder  . The proposed solution does not fix that - but fixes the lookup for folders since a fix of the original error would create new folders. 

       

        Attachments

          Activity

            People

            Assignee:
            tuekorsgaard Tue Korsgaard
            Reporter:
            tuekorsgaard Tue Korsgaard
            Peer reviewer:
            Simey Lameze
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours
                2h