Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64821

Create new discussion view for forum

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test

      The test for these changes is to go through the forum functionality and confirm that it all still works with the new display mode and that the new display mode matches the prototype (excluding the differences mentioned in this comment)

      To begin:

      1. Create a site with a course
      2. Add some users to the site and enrol them in the course with various roles (student, teacher etc). Make sure at least one user is not enrolled.
      Create a standard forum
      1. Create a standard forum
      2. Add a new discussion
      3. Add a few posts to the discussion from a few different users
        • Include images in the post message for a few of them
      4. Log in as each user from different roles and view the discussion
      5. Change the display mode to the "modern" display mode
      6. Try each of the different features of the discussion
        1. Pin it
        2. Move it
        3. Subscribe
        4. All of the post functionality (edit, delete, split etc)
      Add some posts with tags
      1. Create a post and add some tags to it
      2. View the post and click on the tags
      Add some posts with attachments
      1. Create one or more posts with attachments.
      2. Add a combination of files and images
      Deleted user
      1. Log in as admin
      2. Go to the user list (site administration > users > browse list of users)
      3. Delete a user that has:
        1. one or more posts in a discussion
        2. has other user's that have replies to their post
        3. has started a discussion
      4. Approve the user delete data request in the data requests page (site administration > users > privacy and policies > data requests)
      5. Run cron
      6. View the forum
      7. CONFIRM that the deleted user's posts are all deleted and replaced with "This forum post has been removed" text
      8. CONFIRM that the replies to those posts say "in reply to Deleted user" in the header
      User read tracking
      1. Log in as a user with access to the forum
      2. Go to the user’s preference page (from the user menu up the top right)
      3. Click on “forum preferences”
      4. Turn on forum tracking
      5. View the forum
      6. You should see that there are unread posts in the discussion
      7. View the discussion and the unread posts should be marked with a blue flag icon, if you hover the icon it should give you a tooltip saying that it's an unread post.
      8. If you navigate away and then back to the discussion the posts should no longer be flagged (since you’ve seen them)
      Word counts
      1. Edit the forum and turn on display word counts
      2. View a discussion to see the word counts
      Ratings
      1. Edit the form and enable ratings
      2. Setting the “Aggregate type” to “Average of ratings” and leaving the scale as point should do it
      3. View the discussion to see the ratings
      4. Log in as a few different users to check visibility of the ratings
      5. Add some ratings if the user has the capability
      Exporting (portfolios)
      1. Log in as admin
      2. Enable portfolios (see docs)
        • The file download portfolio works well
      3. After enabling portfolios log in as different users and view some discussions
      4. You should have the option to export posts created by that user
      Group forum
      1. Create some groups in the course (make sure you add a group image)
      2. Add some users to the groups
      3. Create a forum in a group mode (under “Common module settings”)
      4. Make sure you're viewing the forum in the "modern" display mode
      5. Log in as a few different users in different groups and try to create and view discussions
      6. Try creating discussions for specific groups (the group setting when creating a discussion)
      7. Try changing the group mode for the forum to the other mode

      Regression test

      1. Change the forum view to each of the other display modes
      2. Try replying to posts using the in page reply
      3. CONFIRM that the replies are added to the correct place in the page (the same as without these changes)

      Create a single discussion forum

      1. Log in as a teacher/admin
      2. Create a forum activity and set the type to "single discussion"
      3. Add the first post to the discussion
      4. CONFIRM that you can change the discussion view to the "modern" view and the display updated to look like the new discussion view
        • Note: The header section of the page will look like the regular forum view page (like the one that lists the discussions for a standard type forum)
      5. CONFIRM that you can reply to posts

      Create each of the other forum types

      1. Log in as a teacher/admin
      2. Create a forum activity and create an instance of each of the other forum types
      3. CONFIRM that they behave as they did prior to the patch; there were no changes to those forum types.
      Show
      Test The test for these changes is to go through the forum functionality and confirm that it all still works with the new display mode and that the new display mode matches the prototype (excluding the differences mentioned in this comment ) To begin: Create a site with a course Add some users to the site and enrol them in the course with various roles (student, teacher etc). Make sure at least one user is not enrolled. Create a standard forum Create a standard forum Add a new discussion Add a few posts to the discussion from a few different users Include images in the post message for a few of them Log in as each user from different roles and view the discussion Change the display mode to the "modern" display mode Try each of the different features of the discussion Pin it Move it Subscribe All of the post functionality (edit, delete, split etc) Add some posts with tags Create a post and add some tags to it View the post and click on the tags Add some posts with attachments Create one or more posts with attachments. Add a combination of files and images Deleted user Log in as admin Go to the user list (site administration > users > browse list of users) Delete a user that has: one or more posts in a discussion has other user's that have replies to their post has started a discussion Approve the user delete data request in the data requests page (site administration > users > privacy and policies > data requests) Run cron View the forum CONFIRM that the deleted user's posts are all deleted and replaced with "This forum post has been removed" text CONFIRM that the replies to those posts say "in reply to Deleted user" in the header User read tracking Log in as a user with access to the forum Go to the user’s preference page (from the user menu up the top right) Click on “forum preferences” Turn on forum tracking View the forum You should see that there are unread posts in the discussion View the discussion and the unread posts should be marked with a blue flag icon, if you hover the icon it should give you a tooltip saying that it's an unread post. If you navigate away and then back to the discussion the posts should no longer be flagged (since you’ve seen them) Word counts Edit the forum and turn on display word counts View a discussion to see the word counts Ratings Edit the form and enable ratings Setting the “Aggregate type” to “Average of ratings” and leaving the scale as point should do it View the discussion to see the ratings Log in as a few different users to check visibility of the ratings Add some ratings if the user has the capability Exporting (portfolios) Log in as admin Enable portfolios (see docs ) The file download portfolio works well After enabling portfolios log in as different users and view some discussions You should have the option to export posts created by that user Group forum Create some groups in the course (make sure you add a group image) Add some users to the groups Create a forum in a group mode (under “Common module settings”) Make sure you're viewing the forum in the "modern" display mode Log in as a few different users in different groups and try to create and view discussions Try creating discussions for specific groups (the group setting when creating a discussion) Try changing the group mode for the forum to the other mode Regression test Change the forum view to each of the other display modes Try replying to posts using the in page reply CONFIRM that the replies are added to the correct place in the page (the same as without these changes) Create a single discussion forum Log in as a teacher/admin Create a forum activity and set the type to "single discussion" Add the first post to the discussion CONFIRM that you can change the discussion view to the "modern" view and the display updated to look like the new discussion view Note: The header section of the page will look like the regular forum view page (like the one that lists the discussions for a standard type forum) CONFIRM that you can reply to posts Create each of the other forum types Log in as a teacher/admin Create a forum activity and create an instance of each of the other forum types CONFIRM that they behave as they did prior to the patch; there were no changes to those forum types.
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull Master Branch:
      MDL-64821-master-2
    • Story Points:
      1
    • Sprint:
      Sprint 5 - Sander's special, Sprint 6 - Looney Tunes, Sprint 7 - Race to the freeze

      Description

      Create a new discussion view mode that matches the prototype.

      Prototype:
      https://projects.invisionapp.com/share/2ATP7L7JYXP#/screens/381579783
      (previously https://projects.invisionapp.com/share/9GQ8R2O3H7J#/screens/350489133)

      Beyond scope of this issue:

      • Discussion header content (e.g. subscribed button, settings, view selector, move discussion selector etc) can all remain as is for now
      • Badges images being moved into a modal. For this issue they can just be rendered under the user image as they are in the other views
      • Emoji reactions
      • The top header part of the prototype with filters, grading, settings etc

      Acceptance criteria

      • UI should match the prototype as closely as possible
      • All content for posts should be included when enabled, e.g. attachments, word counts, ratings etc
      • Accessibility should not be made worse, i.e. keyboard navigation, contrast ratios, screen reader labels etc

        Attachments

        1. moodle.css.diff
          43 kB
        2. Screenshot_1.png
          Screenshot_1.png
          133 kB
        3. Screenshot_2.png
          Screenshot_2.png
          383 kB
        4. Screenshot_3.png
          Screenshot_3.png
          168 kB
        5. Screenshot_4.png
          Screenshot_4.png
          274 kB
        6. Screenshot_5.png
          Screenshot_5.png
          137 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                11 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 weeks, 1 day, 2 hours, 12 minutes
                  2w 1d 2h 12m