Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64823

tool_mobile/disabledfeatures admin setting uses old prefix for plugins

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5.4, 3.6.2
    • Fix Version/s: 3.7
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide

      Before applying the patch:

      • Enable mobile app access to your moodle site.
      • Install a plugin that has mobile support (e.g. mod_certificate).
      • Add an instance to a course on your site
      • Go to Site Administration > Mobile features, and select the plugin under "Remote add-ons" in the "Disabled features" setting
      • Load the app in a web browser (e.g. https://mobileapp.moodledemo.net/) open the developer tools (F12) and select the Network tab
      • Connect to your moodle site and log in.
      • Find the web service request for tool_mobile_get_config. View the response.
        • Verify that it contains the "tool_mobile_disabledfeatures" setting with the value "remoteAddOn_component_name_plugin_name"
      • Verify that the plugin is accessible through the app.

      After applying the patch:

      • Run the upgrade script
      • Reload the app and check the web service request for tool_mobile_get_config again.
        • Verify that it contains the "tool_mobile_disabledfeatures" setting with the value "sitePlugin_component_name_plugin_name"
      • Try to access the plugin in the app.  You should be pushed out to the website.
      • Go to Site Administration > Mobile features, and de-select the plugin under "Remote add-ons" in the "Disabled features" setting
      • Reload the app
      • Try to access the plugin in the app.  You should now be able to.
      • Go to Site Administration > Mobile features, and select the plugin under "Remote add-ons" in the "Disabled features" setting again.
      • Reload the app and check the web service request for tool_mobile_get_config again.
        • Verify that it contains the "tool_mobile_disabledfeatures" setting with the value "sitePlugin_component_name_plugin_name"
      • Try to access the plugin in the app.  You should be pushed out to the website.
      Show
      Before applying the patch: Enable mobile app access to your moodle site. Install a plugin that has mobile support (e.g. mod_certificate). Add an instance to a course on your site Go to Site Administration > Mobile features, and select the plugin under "Remote add-ons" in the "Disabled features" setting Load the app in a web browser (e.g. https://mobileapp.moodledemo.net/) open the developer tools (F12) and select the Network tab Connect to your moodle site and log in. Find the web service request for tool_mobile_get_config . View the response. Verify that it contains the "tool_mobile_disabledfeatures" setting with the value "remoteAddOn_component_name_plugin_name" Verify that the plugin is accessible through the app. After applying the patch: Run the upgrade script Reload the app and check the web service request for tool_mobile_get_config again. Verify that it contains the "tool_mobile_disabledfeatures" setting with the value "sitePlugin_component_name_plugin_name" Try to access the plugin in the app.  You should be pushed out to the website. Go to Site Administration > Mobile features, and de-select the plugin under "Remote add-ons" in the "Disabled features" setting Reload the app Try to access the plugin in the app.  You should now be able to. Go to Site Administration > Mobile features, and select the plugin under "Remote add-ons" in the "Disabled features" setting again. Reload the app and check the web service request for tool_mobile_get_config again. Verify that it contains the "tool_mobile_disabledfeatures" setting with the value "sitePlugin_component_name_plugin_name" Try to access the plugin in the app.  You should be pushed out to the website.
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull Master Branch:
      MDL-64823_master

      Description

      Mobile plugins listed as part of the tool_mobile/disabledfeatures use keys in the format 'remoteAddOn_' . $plugin['component'] . '' . $plugin['addon'].  However, when the app checks this setting to decide if a plugin is disabled in CoreSite.isFeatureDisabled(), it looks for 'sitePlugin' . $plugin['component'] . '_' . $plugin['addon'].  This means its impossible to disable a mobile plugin.

       

        Balsamiq Wireframes

          Attachments

          1. disabled.png
            disabled.png
            606 kB
          2. MDL-64823.bmpr
            15 kB

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  20/May/19