Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64835

Session storage is not emptied on jsrev bump

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.4.7, 3.5.4, 3.6.2, 3.7
    • Fix Version/s: 3.4.8, 3.5.5, 3.6.3
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide
      1. Disable JS dev (mdk run undev)
      2. Open you site
      3. Open dev tools in your browser
      4. Open the session storage:
        1. Chrome:
          1. Choose Application tab
          2. Choose Storage => Local storage from the left-hand side
      5. Select the first key in the list
        1. Note the prefix for the keys - i.e. if the key is -1236003692/core/iconmap-fontawesome then the prefis is -1236003692
      6. Use the filter to search for /jsrev
        1. Make a note of the key and value
      7. Purge caches in your Moodle instance (admin/cli/purge_caches.php in console)
      8. Refresh the browser page
      9. Check the storage cache again
      10. Search for the old prefix
        1. Confirm that no entries were found
      11. Search for /jsrev again
        1. Confirm that the key is the same
      Show
      Disable JS dev ( mdk run undev ) Open you site Open dev tools in your browser Open the session storage: Chrome: Choose Application tab Choose Storage => Local storage from the left-hand side Select the first key in the list Note the prefix for the keys - i.e. if the key is -1236003692/core/iconmap-fontawesome then the prefis is -1236003692 Use the filter to search for /jsrev Make a note of the key and value Purge caches in your Moodle instance (admin/cli/purge_caches.php in console) Refresh the browser page Check the storage cache again Search for the old prefix Confirm that no entries were found Search for /jsrev again Confirm that the key is the same
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull 3.5 Diff URL:
    • Pull Master Branch:
      MDL-64835-master
    • Pull Master Diff URL:

      Description

      1. Disable JS dev (mdk run undev)
      2. Open you site
      3. Open dev tools in your browser
      4. Open the session storage:
        1. Chrome:
          1. Choose Application tab
          2. Choose Storage => Local storage from the left-hand side
          3. Note the prefix for the keys - i.e. if the key is -1236003692/core/iconmap-fontawesome then the prefis is -1236003692
      5. Purge caches in your Moodle instance (admin/cli/purge_caches.php in console)
      6. Refresh the browser page
      7. Check the storage cache again
        1. Note that the session storage cache was not emptied and that there are keys with the old prefix still exist

        Attachments

          Activity

            People

            Assignee:
            dobedobedoh Andrew Nicols
            Reporter:
            dobedobedoh Andrew Nicols
            Peer reviewer:
            Ryan Wyllie
            Integrator:
            Jun Pataleta
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Mar/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 50 minutes
                2h 50m