Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64853

[UX Required] Upgrade Font Awesome library to latest Fork Awesome library

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_400_STABLE
    • Pull Master Branch:
      MDL-64853-master
    • Testing Instructions:
      Hide
      Icons check
      1. We need two moodle sites:
        1. One with this patch applied (let's call this the "After" site)
        2. Another instance without this patch. (let's call this the "Before" site)
      2. Copy test.php to both of these instances' root folder.
      3. Open test.php on your browser for both of the moodle sites. Might help to line these browser windows side by side.
      4. Compare the pix_icon columns of the "Before" and "After" sites.
      5. Confirm that the icons for the "Before" and "After" sites are similar. The "After" site might be a bit thicker than the "Before" site's icons.
      6. Confirm that there are no blank pix_icon entries on the "After" site. Exceptions are those with the following icon names:
        • fa-fw
        • fa-spacer
      Data registry
      1. Log in as a site admin.
      2. Make sure that your site has at least one course with a few activities.
      3. Go to Site administration / Users/ Privacy and policies / Data registry.
      4. On the data registry's tree, expand the "Courses" node.
      5. Confirm that for a moment, the icon changes to a spinning circle ("fa fa-circle-notch fa-spin" in test.php) and then changes back to a minus sign ("fa fa-minus")
      6. Collapse the node.
      7. Confirm that it changes back to a plus sign ("fa fa-plus")
      Show
      Icons check We need two moodle sites: One with this patch applied (let's call this the "After" site) Another instance without this patch. (let's call this the "Before" site) Copy test.php to both of these instances' root folder. Open test.php on your browser for both of the moodle sites. Might help to line these browser windows side by side. Compare the pix_icon columns of the "Before" and "After" sites. Confirm that the icons for the "Before" and "After" sites are similar. The "After" site might be a bit thicker than the "Before" site's icons. Confirm that there are no blank pix_icon entries on the "After" site. Exceptions are those with the following icon names: fa-fw fa-spacer Data registry Log in as a site admin. Make sure that your site has at least one course with a few activities. Go to Site administration / Users/ Privacy and policies / Data registry. On the data registry's tree, expand the " Courses " node. Confirm that for a moment, the icon changes to a spinning circle (" fa fa-circle-notch fa-spin " in test.php) and then changes back to a minus sign (" fa fa-minus ") Collapse the node. Confirm that it changes back to a plus sign (" fa fa-plus ")
    • Story Points:
      2
    • Sprint:
      Sprint 2 - Experimental

      Description

      We are using an unsupported version (4.7). We should upgrade to the current fork awesome library.

        Attachments

        1. FA4vsFA5.png
          FA4vsFA5.png
          1.43 MB
        2. fontawesome-5.png
          fontawesome-5.png
          1.02 MB
        3. test.php
          1 kB

          Issue Links

            Activity

              People

              Assignee:
              basbrands Bas Brands
              Reporter:
              markn Mark Nelson
              Participants:
              Component watchers:
              Huong Nguyen, Bas Brands, Mathew May, Huong Nguyen, Barbara Ramiro, Bas Brands, Mathew May
              Votes:
              4 Vote for this issue
              Watchers:
              24 Start watching this issue

                Dates

                Created:
                Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 minute
                  1m